[9] Review request: 8170702: Document that javafx.graphics needs explicit access to application main class

Kevin Rushforth kevin.rushforth at oracle.com
Mon Mar 6 15:19:34 UTC 2017



Mandy Chung wrote:
>> On Mar 4, 2017, at 5:15 PM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~kcr/8170702/webrev.01/
>>     
>
> Nit: @linkplain will show the normal font as text in javadoc rather than like the font for {@code…} 
>   

Right...see my other reply. I'm happy to make this change if you plan to 
do the same for the rest of the JDK.


>  209      * be a public subclass of Application, in a package that is
>  210      * {@link Module#isExported(String,Module) exported} to at least the
>  211      * {@code javafx.graphics} module, or a RuntimeException will be thrown.
>
> Should it mention the public constructor?  No need to have a new webrev if you update this before you push.
>   

A good point, yes, I will add this.

-- Kevin


> Mandy
>
>   


More information about the openjfx-dev mailing list