Should there be getter methods in LabeledSkinBase?

[Thorsten_Fischer at gmx.de]

Hi there,

I’m currently working on creating a new JavaFX control with jdk 9 (latest ea release). Now I have a question regarding the ‚LabeledSkinBase‘ class. (I’d like implement something similar to a TitledPane and the corresponding Skin class extends from LabeledSkinBase).

I’d really like to rely on some parts of LabeledSkinBase (like the JDK’s TitledPaneSkin class does in its update() method), but I cannot access the package protected declared fields, like „LabeledText text". Why are there no getters implemented for them? This means, that your own shipped controls may rely on the LabeledSkinBase class and I sadly cannot. On a field like "Node graphic" I can work around myself with getSkinnable().getGraphic() but imho this als would be cleaner with specific getters supplied. This applies also to utility methods of LabeledSkinBase, like isIgnoreGraphic().

I know that even with JDK-8077916 (making UI controls Skins public API) your goal was to make only the minimal necessary API public, but in this case I cannot reuse this class at all.. Or do I miss something? Are there public alternatives? Should I even use this class? Would be nice if someone can give his/her opinion on this one.

Thank you in advance,
Thorsten