openjfx-dev Digest, Vol 71, Issue 15
Nir Lisker
nlisker at gmail.com
Fri Oct 13 12:24:02 UTC 2017
Hi,
Thanks for the slides Laurent. Was the talk not recorded?
Would like to get in on the community effort discussion. If possible,
include me in it.
Thanks,
Nir
On Fri, Oct 13, 2017 at 3:00 PM, <openjfx-dev-request at openjdk.java.net>
wrote:
> Send openjfx-dev mailing list submissions to
> openjfx-dev at openjdk.java.net
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://mail.openjdk.java.net/mailman/listinfo/openjfx-dev
> or, via email, send a message with subject or body 'help' to
> openjfx-dev-request at openjdk.java.net
>
> You can reach the person managing the list at
> openjfx-dev-owner at openjdk.java.net
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of openjfx-dev digest..."
>
>
> Today's Topics:
>
> 1. [10] Review request : JDK-8172856 : Out of memory exception
> due to repeated style class changes (Ambarish Rapte)
> 2. Multiselection in a TreeView (Scott Palmer)
> 3. Result: New OpenJFX Committer: Prasanta Sadhukhan
> (Kevin Rushforth)
> 4. Re: [10] Review request for 8185634, 8185634: Java Fx-Swing
> dialogs appearing behind main stage (Sergey Bylokhov)
> 5. JavaOne slides about Marlin/FX renderer (Laurent Bourg?s)
> 6. Re: JavaOne slides about Marlin/FX renderer (John-Val Rose)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 12 Oct 2017 05:53:01 -0700 (PDT)
> From: Ambarish Rapte <ambarish.rapte at oracle.com>
> To: openjfx-dev at openjdk.java.net, Kevin Rushforth
> <kevin.rushforth at oracle.com>, Ajit Ghaisas <
> ajit.ghaisas at oracle.com>
> Subject: [10] Review request : JDK-8172856 : Out of memory exception
> due to repeated style class changes
> Message-ID: <09c62752-05ac-49b0-a7de-21f3d89f3f93 at default>
> Content-Type: text/plain; charset=us-ascii
>
> Hi,
>
>
>
> Please review the fix:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8172856
>
> Webrev.00: http://cr.openjdk.java.net/~
> arapte/fx/8172856/webrev.00/
>
> Webrev.01: http://cr.openjdk.java.net/~
> arapte/fx/8172856/webrev.01/
>
>
>
> More description about the 2 fixes is mentioned at bug.
>
>
>
>
>
> Regards,
>
> Ambarish
>
>
>
>
> ------------------------------
>
> Message: 2
> Date: Thu, 12 Oct 2017 09:32:28 -0400
> From: Scott Palmer <swpalmer at gmail.com>
> To: OpenJFX Mailing List <openjfx-dev at openjdk.java.net>
> Subject: Multiselection in a TreeView
> Message-ID: <483B679B-24F0-4859-B43E-9D7FC112A22E at gmail.com>
> Content-Type: text/plain; charset=utf-8
>
> Try it. It has a lot of issues.
> - SelectedItems ListChangeListener misses ?Remove? notifications
> - IndexOutOfBoundsExceptions
> - Selection of item by clicking on the collapse-node widget
>
> See https://bugs.openjdk.java.net/browse/JDK-8189228
>
> Scott
>
> ------------------------------
>
> Message: 3
> Date: Thu, 12 Oct 2017 07:10:40 -0700
> From: Kevin Rushforth <kevin.rushforth at oracle.com>
> To: registrar at openjdk.java.net, Prasanta Sadhukhan
> <prasanta.sadhukhan at oracle.com>, "openjfx-dev at openjdk.java.net"
> <openjfx-dev at openjdk.java.net>
> Subject: Result: New OpenJFX Committer: Prasanta Sadhukhan
> Message-ID: <59DF77E0.10203 at oracle.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> Voting for Prasanta Sadhukhan [1] to OpenJFX Committer [2] is now closed.
>
> Yes: 8
> Veto: 0
> Abstain: 0
>
> According to the Bylaws definition of Lazy Consensus, this is sufficient
> to approve the nomination.
>
> -- Kevin
>
> [1] http://openjdk.java.net/census#psadhukhan
> [2]
> http://mail.openjdk.java.net/pipermail/openjfx-dev/2017-
> September/020850.html
>
>
>
> ------------------------------
>
> Message: 4
> Date: Thu, 12 Oct 2017 12:44:42 -0700
> From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
> To: Kevin Rushforth <kevin.rushforth at oracle.com>, Alexander Zvegintsev
> <alexander.zvegintsev at oracle.com>
> Cc: "awt-dev at openjdk.java.net" <awt-dev at openjdk.java.net>,
> "openjfx-dev at openjdk.java.net" <openjfx-dev at openjdk.java.net>
> Subject: Re: [10] Review request for 8185634, 8185634: Java Fx-Swing
> dialogs appearing behind main stage
> Message-ID: <8013fec4-ca01-7701-bc15-2fce01f88ca0 at oracle.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
> Looks fine.
> I am not sure but it looks like the fix has an assumption that the
> CPlatformWindow.setVisible() code will be executed on EDT/Appkit but it
> is not the case. This code can be executed on any thread(intentionally
> for crash), and it will be good to check that it works as expected by
> some stress test which will try to force the possible crash: 4 threads:
> - show/dispose Swing Node
> - show/dispose Dialog1/2/3 using different timeouts
>
> Will the current fix cover the native dialogs like
> FileDialog/PrintDialog on linux and windows?
>
> On 10/10/2017 13:54, Kevin Rushforth wrote:
> > Note that there is now a 04 version.
> >
> > It looks good to me, although someone more familiar with AWT should also
> > check the AWT changes.
> >
> > We will need a test program for this (as a follow-on issue if not now).
> >
> > -- Kevin
> >
> >
> > Alexander Zvegintsev wrote:
> >> Please review the updated version
> >>
> >> http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/
> >> Now we are postponing actual window closing, it happens only after we
> >> ensure that native window pointer is valid on Swing side.
> >>
> >> Thanks,
> >> Alexander.
> >>
> >> On 23/09/2017 08:01, Sergey Bylokhov wrote:
> >>> Hi, Alexander.
> >>> How can we be sure that the parent frame will not be disposed while
> >>> we use a pointer?
> >>>
> >>> long ownerWindowPtr = peer.getOverridenWindowHandle();
> >>> <<<<< Dispose the peer
> >>> if (ownerWindowPtr != 0) {
> >>> ??? //Place window above JavaFX stage
> >>> ??? CWrapper.NSWindow.addChildWindow(
> >>> ??? ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove);
> >>> <<<<< Boom
> >>> }
> >>>
> >>>
> >>> On 9/21/17 22:56, Alexander Zvegintsev wrote:
> >>>> Hi Phil,
> >>>>
> >>>> Please review the updated fix with reflection incorporated
> >>>> http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/
> >>>>
> >>>> New issue created JDK-8187803
> >>>> <https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK
> >>>> counterpart of this issue.
> >>>>
> >>>> Thanks,
> >>>> Alexander.
> >>>>
> >>>> On 21/09/2017 22:25, Phil Race wrote:
> >>>>> Some procedural comments :
> >>>>> Since 90% of this is in AWT code, I'd have thought awt-dev should
> >>>>> be included here.
> >>>>> I've added that list.
> >>>>>
> >>>>> And apart from needing separate bug ids, I don't see why the bug
> >>>>> below is confidential.
> >>>>>
> >>>>>
> >>>>> I agree with what Kevin pointed out off-line that as in the dialog
> >>>>> case, the FX side
> >>>>> of the code can use reflection and simply be a harmless
> >>>>> non-functional no-op
> >>>>> if the SwingAccessor does not provide the new method.
> >>>>>
> >>>>> BTW
> >>>>> 264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
> >>>>> should be "dd" not "d".
> >>>>>
> >>>>> -phil.
> >>>>>
> >>>>> On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:
> >>>>>> Hello,
> >>>>>>
> >>>>>> please review the fix
> >>>>>>
> >>>>>> http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/
> >>>>>>
> >>>>>> for the issue
> >>>>>>
> >>>>>> https://bugs.openjdk.java.net/browse/JDK-8185634
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >>
>
>
> --
> Best regards, Sergey.
>
>
> ------------------------------
>
> Message: 5
> Date: Fri, 13 Oct 2017 11:20:03 +0200
> From: Laurent Bourg?s <bourges.laurent at gmail.com>
> To: marlin-renderer at googlegroups.com
> Cc: "2d-dev at openjdk.java.net" <2d-dev at openjdk.java.net>,
> "openjfx-dev at openjdk.java.net Mailing" <
> openjfx-dev at openjdk.java.net>
> Subject: JavaOne slides about Marlin/FX renderer
> Message-ID:
> <CAKjRUT5Q2bVcweEHvkykH-2P2XS=fLkwP+pcXALxibG=7vd65Q at mail.
> gmail.com>
> Content-Type: text/plain; charset="UTF-8"
>
> Hi,
>
> Here are my final JavaOne slides about the Marlin & MarlinFX renderers:
> https://github.com/bourgesl/bourgesl.github.io/raw/master/ja
> vaone2017/slides/javaone-marlin-talk.pdf
>
> You will also get links to my github repositories...
>
> Please join me in my efforts improving either Java2D or JavaFX
> (performance, quality, better 3D support in JFX) by contributing to the
> Marlin project or sponsoring me working for the java community (OpenJDK &
> OpenJFX).
>
> Cheers,
> Laurent
>
>
> ------------------------------
>
> Message: 6
> Date: Fri, 13 Oct 2017 20:25:29 +1100
> From: John-Val Rose <johnvalrose at gmail.com>
> To: Laurent Bourg?s <bourges.laurent at gmail.com>
> Cc: "2d-dev at openjdk.java.net" <2d-dev at openjdk.java.net>,
> "openjfx-dev at openjdk.java.net Mailing" <
> openjfx-dev at openjdk.java.net>,
> marlin-renderer at googlegroups.com
> Subject: Re: JavaOne slides about Marlin/FX renderer
> Message-ID:
> <CAFKr6yx6NYx1XEsRwLUGFSmXfwJt8KJeRPd5hfE=Y2iobLVgpw at mail.
> gmail.com>
> Content-Type: text/plain; charset="UTF-8"
>
> Hi Laurent,
>
> You have my full support. I have emailed your privately and believe we can
> work together to improve JavaFX in the ways you mentioned.
>
> BTW: MarlinFX is a truly awesome contribution. Thanks on behalf of the
> JavaFX community!
>
> ??
> Graciously,
>
> John-Val Rose
> Chief Scientist/Architect
> Rosethorn Technology
> Australia
>
> On 13 October 2017 at 20:20, Laurent Bourg?s <bourges.laurent at gmail.com>
> wrote:
>
> > Hi,
> >
> > Here are my final JavaOne slides about the Marlin & MarlinFX renderers:
> > https://github.com/bourgesl/bourgesl.github.io/raw/master/ja
> > vaone2017/slides/javaone-marlin-talk.pdf
> >
> > You will also get links to my github repositories...
> >
> > Please join me in my efforts improving either Java2D or JavaFX
> > (performance, quality, better 3D support in JFX) by contributing to the
> > Marlin project or sponsoring me working for the java community (OpenJDK &
> > OpenJFX).
> >
> > Cheers,
> > Laurent
> >
>
>
> End of openjfx-dev Digest, Vol 71, Issue 15
> *******************************************
>
More information about the openjfx-dev
mailing list