Swing module's module-info file

[Tom Schindl]

Hi Nir,

I'm using OpenJDK-11 in my eclipse for development so I have that module
included.

Tom

On 07.08.18 18:34, Nir Lisker wrote:
> So you rebuilt the JDK with the new jdk.unsupported.desktop module?
> 
> On Tue, Aug 7, 2018 at 3:11 PM, Tom Schindl <tom.schindl at bestsolution.at
> <mailto:tom.schindl at bestsolution.at>> wrote:
> 
>     Well I simply added the folder to my class-folders and things then work
>     perfectly fine inside Eclipse
> 
>     Tom
> 
>     On 07.08.18 14:02, Nir Lisker wrote:
>     > Thanks for the info. I'm working on updating the Eclipse files and
>     this is
>     > causing problems for javafx.swing. When will the minimum version
>     be bumped
>     > to 11?
>     >
>     > On Tue, Aug 7, 2018 at 7:51 AM, Prasanta Sadhukhan <
>     > prasanta.sadhukhan at oracle.com
>     <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>     >
>     >> This is because if fx is compiled with a jdk version which does
>     not have
>     >> jdk.unsupported.desktop module then having module-info.java in
>     its original
>     >> place would cause compilation error as module-info.java contains
>     >>
>     >> requires static jdk.unsupported.desktop;
>     >>
>     >> So, the idea was to copy the file into a directory which is not
>     on the
>     >> module-source-path. Then build.gradle copy it from there to gensrc
>     >> directory optionally filtering the above line
>     >>  task copyModuleInfo(type: Copy, description: "copy module-info
>     file to
>     >> gensrc") {
>     >>         from "src/main/module-info/module-info.java"
>     >>         into "$buildDir/gensrc/java/"
>     >>         filter { line->
>     >>             !HAS_UNSUPPORTED_DESKTOP &&
>     line.contains('jdk.unsupported.desktop')
>     >> ? null : line
>     >>         }
>     >>     }
>     >>
>     >> Regards
>     >> Prasanta
>     >>
>     >> On 8/7/2018 6:42 AM, Nir Lisker wrote:
>     >>
>     >>> Hi,
>     >>>
>     >>> I didn't follow all the latest changes to the Swing module, but
>     I notice
>     >>> now its module-info.java file is not in the same place where
>     other modules
>     >>> have theirs:
>     >>>
>     >>> It's under javafx.swing\src\main\module-info instead of
>     >>> javafx.<other>\src\main\java.
>     >>>
>     >>> Is there a reason for this?
>     >>>
>     >>> - Nir
>     >>>
>     >>
>     >>
> 
>     -- 
>     Tom Schindl, CTO
>     BestSolution.at EDV Systemhaus GmbH
>     Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
>     Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> 
> 

-- 
Tom Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck