[8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

[Dipak Kumar]

Hi Semyon,

Could you please review the changes (also have a look at Phil's comment in trailing mail) and let me know your comments.

Thanks Kevin and Phil. I have incorporated the changes suggested for unit tests in JavaFx side. Request you to have a look.

Please find updated webrev at - http://cr.openjdk.java.net/~dkumar/8185634/webrev.01/ .

Thanks,
Dipak

-----Original Message-----
From: Kevin Rushforth 
Sent: Thursday, January 18, 2018 3:21 AM
To: Phil Race <philip.race at oracle.com>
Cc: Dipak Kumar <dipak.kumar at oracle.com>; openjfx-dev at openjdk.java.net; awt-dev at openjdk.java.net
Subject: Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

I think you mean https://bugs.openjdk.java.net/browse/JDK-8187803 for the AWT/Swing side...

-- Kevin


Phil Race wrote:
> The AWT/Swing side of this needs to be bug
> https://bugs.openjdk.java.net/browse/JDK-8185634
>
> One thing I notice is that in XWindowPeer.java the calculation for the 
> value of transientForWindow is different .. because you don't have the 
> fix for
> https://bugs.openjdk.java.net/browse/JDK-8021961 :
> "setAlwaysOnTop doesn't behave correctly in Linux/Solaris under 
> certain scenarios"
>
> Do you first need to backport that too ? Maybe Semyon (who authored 
> that fix) can say whether it matters ..
>
> -phil.
>
> On 01/12/2018 02:12 AM, Dipak Kumar wrote:
>> Hi All,
>>
>>  
>> Please review the below patch (for 8u-backport) -
>>
>>  
>> Webrev : http://cr.openjdk.java.net/~dkumar/8185634/webrev.00/
>>
>> JBS - https://bugs.openjdk.java.net/browse/JDK-8185634
>>
>>  
>> Thanks,
>>
>> Dipak
>