Proposal For Inclusion of Robot and ParametersImpl in the Public API

Kevin Rushforth kevin.rushforth at oracle.com
Mon Mar 26 14:54:39 UTC 2018


Seems good to me, too.

-- Kevin


Michael Ennen wrote:
> Sounds like a good idea to me to only have `getScreenCapture` methods
> that have a WritableImage parameter which can be `null` which means a
> new WritableImage will be created otherwise the given one is re-used, as
> in Scene.snapshot and Node.snapshot. What are your thoughts on this,
> Kevin?
>
> On Sat, Mar 24, 2018 at 6:11 PM, Scott Palmer <swpalmer at gmail.com 
> <mailto:swpalmer at gmail.com>> wrote:
>
>
>
>>     On Mar 23, 2018, at 5:50 PM, Michael Ennen <mike.ennen at gmail.com
>>     <mailto:mike.ennen at gmail.com>> wrote:
>>
>>     Kevin,
>>
>>     I believe I followed all of your suggestions, except the one with a
>>     re-usable WritableImage.
>>     If you want me to implement that as well, I can, but you seemed
>>     unsure
>>     about the necessity
>>     of it.
>
>     I think it should be included to reduce garbage generated in a
>     case where repeated captures is used.  Such as a desktop sharing
>     application, a screen recorder, etc.
>     It would also be consistent with the node.snapshot API.
>
>     In fact, I would just have the version that takes a WriteableImage
>     and match the behaviour of node.snapshot.
>
>     Scott
>
>
>
>
> -- 
> Michael Ennen


More information about the openjfx-dev mailing list