Review request for #151 Open VirtualFlow and other relating classes API for sublclassing
Kevin Rushforth
kevin.rushforth at oracle.com
Mon Oct 15 13:00:27 UTC 2018
Note that since this is request for a new feature there are a couple
other steps needed:
1. The proposed feature, along with the new API should be discussed and
general agreement reached. This is already in progress and is happening
in the PR itself. Mainly what needs to be ironed out now is to make sure
that each new API method is needed, and its purpose and use is well
understood and documents. Some of you have already provided valuable
feedback on this.
2. Once we have general agreement on the API additions, a CSR will be
needed (Eugene has graciously agreed to file it with my help). The CSR
will then need review / approval from a lead: Johan or myself.
The code review can proceed in parallel with #2 -- it will need (at
least) two reviewers.
With Oracle Code One approaching, I expect there will be some delay in
the first two items, but we still have plenty of time to get this in for
openjfx12.
Thanks!
-- Kevin
On 10/15/2018 5:27 AM, Sam' wrote:
> Please review the GitHub pull request:
> https://github.com/javafxports/openjdk-jfx/pull/163
> <https://github.com/javafxports/openjdk-jfx/pull/235>
>
> which fixes:
>
>
> Open VirtualFlow API for subclassing
>
> https://github.com/javafxports/openjdk-jfx/issues/151
> <https://bugs.openjdk.java.net/browse/JDK-8188810>
>
> Thank you,
> Samir
More information about the openjfx-dev
mailing list