Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

[Kevin Rushforth]

Yes, it should be "isImageSmoothing", thanks for catching this!

This looks good to me to other than that.

The only other comment is that when you write the docs, make sure you 
indicate that this applies to drawImage calls, both in the docs of the 
new setImageSmooth method, and in the docs of the drawImage calls. 
Perhaps you post the proposed javadoc changes, since they will be needed 
for the CSR?

-- Kevin


On 10/15/2018 3:36 PM, Dan Howard wrote:
> Shouldn't it be "is" rather than "get" for boolean?  Other than that, 
> sounds good!
>
>
> On 10/15/2018 3:29 PM, Ambarish Rapte wrote:
>> Hi All,
>>
>>
>> This email is for discussion regarding the fix 
>> https://bugs.openjdk.java.net/browse/JDK-8204060 .
>>
>>
>> Issue:
>>
>> Images drawn using javafx.scene.canvas .GraphicsContext::drawImage() 
>> always apply filtering to the image.
>>
>>
>> Solution:
>>
>> javafx.scene.canvas.GraphicsContext should provide an option to 
>> enable and disable smoothing.
>>
>>
>> Proposal:
>>
>> Adding a Boolean flag & APIs to control smoothing.
>>
>>
>> Add a boolean flag to control smoothing
>> Add two public APIs
>>
>> public void setImageSmoothing(boolean imageSmoothing) {} to enable or 
>> disable smoothing.
>> public boolean getImageSmoothing() {}
>>
>> If image smoothing is true, images will be scaled using a higher 
>> quality filtering when transforming or scaling the source image to 
>> fit in the destination rectangle.
>> If image smoothing is false, images will be scaled without filtering 
>> (or by using a lower quality filtering) when transforming or scaling 
>> the source image to fit in the destination rectangle.
>>
>>
>> Please provide your comments on the proposal.
>>
>>
>>
>> Regards,
>>
>> Ambarish
>>
>