From rolf-martin.woersinger at sap.com Thu Aug 1 12:38:25 2019 From: rolf-martin.woersinger at sap.com (Woersinger, Rolf-Martin) Date: Thu, 1 Aug 2019 12:38:25 +0000 Subject: ECCN for OpenJFX 11+? Message-ID: <37D2034C-7A0C-4504-8A4E-31596DDC5763@sap.com> Hi, I am locking for the ECCN (Export Control Classification Number) document of OpenJFX 11 and newer. Java SE 11, I found in [1]. The ECCN might be the same, but since OpenJFX is no longer part of the JDK, I would expect a separate classification. Any idea where to find it? Thanks and best regards Rolf-Martin [1] http://www.oracle.com/us/products/export/eccn-matrix-software-412042.pdf From kevin.rushforth at oracle.com Thu Aug 1 13:03:46 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Thu, 1 Aug 2019 06:03:46 -0700 Subject: ECCN for OpenJFX 11+? In-Reply-To: <37D2034C-7A0C-4504-8A4E-31596DDC5763@sap.com> References: <37D2034C-7A0C-4504-8A4E-31596DDC5763@sap.com> Message-ID: <5007b26f-aeb3-cee0-34de-3af88b887556@oracle.com> Oracle does not distribute OpenJFX 11 (or later) binaries, so this would be a question for Gluon. -- Kevin On 8/1/2019 5:38 AM, Woersinger, Rolf-Martin wrote: > Hi, > > I am locking for the ECCN (Export Control Classification Number) document of OpenJFX 11 and newer. > Java SE 11, I found in [1]. > The ECCN might be the same, but since OpenJFX is no longer part of the JDK, I would expect a separate classification. > Any idea where to find it? > > Thanks and best regards > Rolf-Martin > [1]http://www.oracle.com/us/products/export/eccn-matrix-software-412042.pdf From kevin.rushforth at oracle.com Thu Aug 1 17:57:23 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Thu, 1 Aug 2019 10:57:23 -0700 Subject: [13] RFR: JDK-8226782: Update copyright header for files modified in 2019 Message-ID: <72429e42-d459-0a89-622d-18545f55d7f1@oracle.com> Hi Ambarish, Please review the following simple copyright year change. https://bugs.openjdk.java.net/browse/JDK-8226782 https://github.com/javafxports/openjdk-jfx/pull/547 -- Kevin From thiago.sayao at clamed.com.br Sat Aug 3 22:41:49 2019 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Sat, 3 Aug 2019 22:41:49 +0000 Subject: Building on windows Message-ID: Hi, I have followed the instructions on: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows When running ./gradlew.bat on cygwin I get: > FAIL: WINSDK_DIR not defined My version is 14.16.27012. Thanks. From mike.ennen at gmail.com Sun Aug 4 00:02:35 2019 From: mike.ennen at gmail.com (Michael Ennen) Date: Sat, 3 Aug 2019 17:02:35 -0700 Subject: Building on windows In-Reply-To: References: Message-ID: Hello Thiago, I would recommend using the following powershell script to build OpenJFX locally on Windows: https://github.com/javafxports/openjdk-jfx/blob/develop/tools/scripts/build.ps1 The only prerequisite needed to run that script is the chocolatey package manager (https://chocolatey.org/). It would probably be an improvement to the script if it checked for the existence of chocolatey install and if it is not find print a more helpful error message. If you don't want to install Cygwin you can use the `-nocygwin` argument otherwise the script will try to auto-install it using Chocolatey. On Sat, Aug 3, 2019 at 3:42 PM Thiago Milczarek Sayao < thiago.sayao at clamed.com.br> wrote: > Hi, > > I have followed the instructions on: > > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows > > When running ./gradlew.bat on cygwin I get: > > > FAIL: WINSDK_DIR not defined > > My version is 14.16.27012. > > > Thanks. > -- Michael Ennen From mp at jugs.org Sun Aug 4 13:38:02 2019 From: mp at jugs.org (Michael Paus) Date: Sun, 4 Aug 2019 15:38:02 +0200 Subject: RFR: JDK-8220396: Bindings class gives a lot of unneeded 'select-binding' log messages Message-ID: <0ead202e-dcf7-e917-4c22-4befe089be90@jugs.org> Hi Kevin, please review my fix for "JDK-8220396: Bindings class gives a lot of unneeded 'select-binding' log messages" https://bugs.openjdk.java.net/browse/JDK-8220396 https://github.com/javafxports/openjdk-jfx/issues/383 https://github.com/javafxports/openjdk-jfx/pull/550 From thiago.sayao at clamed.com.br Mon Aug 5 01:25:40 2019 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Mon, 5 Aug 2019 01:25:40 +0000 Subject: Building on windows In-Reply-To: References: Message-ID: Managed to get past the error by updating the source tree. Now I'm getting this: > FAIL: cannot find RC: C:/Program Files (x86)/Windows Kits/10/Bin//rc.exe Seems to be failing to get CPU architecture. Mine is x64 (AMD Ryzen). Chocolatey gives me the same error. Cheers. ________________________________ De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: s?bado, 3 de agosto de 2019 19:41 Para: openjfx-dev at openjdk.java.net Assunto: Building on windows Hi, I have followed the instructions on: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows When running ./gradlew.bat on cygwin I get: > FAIL: WINSDK_DIR not defined My version is 14.16.27012. Thanks. From openjdk at carl.pro Mon Aug 5 07:06:06 2019 From: openjdk at carl.pro (Tasha CARL) Date: Mon, 05 Aug 2019 09:06:06 +0200 Subject: Building on windows In-Reply-To: References: Message-ID: "Windows Kits/10/Bin//rc.exe" is tool form the Windows SDK. I did not try a built myself, but it might be very well needed to build the platform specific binaries. https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk Hope this helps. Nat On Mon, 5 Aug 2019, at 3:28 AM, Thiago Milczarek Sayao wrote: > Managed to get past the error by updating the source tree. > > Now I'm getting this: > > FAIL: cannot find RC: C:/Program Files (x86)/Windows Kits/10/Bin//rc.exe > > Seems to be failing to get CPU architecture. > > Mine is x64 (AMD Ryzen). > > Chocolatey gives me the same error. > > Cheers. > ________________________________ > De: openjfx-dev em nome de > Thiago Milczarek Sayao > Enviado: s?bado, 3 de agosto de 2019 19:41 > Para: openjfx-dev at openjdk.java.net > Assunto: Building on windows > > Hi, > > I have followed the instructions on: > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows > > When running ./gradlew.bat on cygwin I get: > > > FAIL: WINSDK_DIR not defined > > My version is 14.16.27012. > > > Thanks. > From nlisker at gmail.com Mon Aug 5 10:44:33 2019 From: nlisker at gmail.com (Nir Lisker) Date: Mon, 5 Aug 2019 13:44:33 +0300 Subject: Building on windows In-Reply-To: References: Message-ID: The double slash in "Bin//rc.exe" is weird, there should be a folder there. If it helps, build.gradle has this comment on line 40: > The genVSproperties.bat doesn't find the directory where RC.exe lives. So it is hard coded. Might be a problem. I never hit this problem. - Nir On Mon, Aug 5, 2019 at 4:26 AM Thiago Milczarek Sayao < thiago.sayao at clamed.com.br> wrote: > Managed to get past the error by updating the source tree. > > Now I'm getting this: > > FAIL: cannot find RC: C:/Program Files (x86)/Windows Kits/10/Bin//rc.exe > > Seems to be failing to get CPU architecture. > > Mine is x64 (AMD Ryzen). > > Chocolatey gives me the same error. > > Cheers. > ________________________________ > De: openjfx-dev em nome de Thiago > Milczarek Sayao > Enviado: s?bado, 3 de agosto de 2019 19:41 > Para: openjfx-dev at openjdk.java.net > Assunto: Building on windows > > Hi, > > I have followed the instructions on: > > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows > > When running ./gradlew.bat on cygwin I get: > > > FAIL: WINSDK_DIR not defined > > My version is 14.16.27012. > > > Thanks. > From thiago.sayao at clamed.com.br Tue Aug 6 00:46:17 2019 From: thiago.sayao at clamed.com.br (Thiago Milczarek Sayao) Date: Tue, 6 Aug 2019 00:46:17 +0000 Subject: Building on windows In-Reply-To: References: , Message-ID: win.gradle line 155: //if (WINDOWS_VS_VER != "100") { winSdkBinDir += "/$CPU_BITS" //} I have Windows 10, so commenting the if resolved the problem. Wonder why it's there... ________________________________ De: Nir Lisker Enviado: segunda-feira, 5 de agosto de 2019 07:44 Para: Thiago Milczarek Sayao Cc: openjfx-dev at openjdk.java.net Assunto: Re: Building on windows The double slash in "Bin//rc.exe" is weird, there should be a folder there. If it helps, build.gradle has this comment on line 40: > The genVSproperties.bat doesn't find the directory where RC.exe lives. So it is hard coded. Might be a problem. I never hit this problem. - Nir On Mon, Aug 5, 2019 at 4:26 AM Thiago Milczarek Sayao > wrote: Managed to get past the error by updating the source tree. Now I'm getting this: > FAIL: cannot find RC: C:/Program Files (x86)/Windows Kits/10/Bin//rc.exe Seems to be failing to get CPU architecture. Mine is x64 (AMD Ryzen). Chocolatey gives me the same error. Cheers. ________________________________ De: openjfx-dev > em nome de Thiago Milczarek Sayao > Enviado: s?bado, 3 de agosto de 2019 19:41 Para: openjfx-dev at openjdk.java.net > Assunto: Building on windows Hi, I have followed the instructions on: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows When running ./gradlew.bat on cygwin I get: > FAIL: WINSDK_DIR not defined My version is 14.16.27012. Thanks. From johan.vos at gluonhq.com Tue Aug 6 08:27:25 2019 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 6 Aug 2019 10:27:25 +0200 Subject: RFR: JDK-8228766: Platform.startup() deadlock on mac Message-ID: Hi, Please review PR #543 [1] which fixes issue #542 [2] or JDK-8228766 [3]. Thanks, - Johan [1] https://github.com/javafxports/openjdk-jfx/pull/543 [2] https://github.com/javafxports/openjdk-jfx/issues/542 [3] https://bugs.openjdk.java.net/browse/JDK-8228766 From org.openjdk at io7m.com Tue Aug 6 18:11:42 2019 From: org.openjdk at io7m.com (Mark Raynsford) Date: Tue, 6 Aug 2019 19:11:42 +0100 Subject: Concatenating transforms to scale positions but not objects Message-ID: <20190806191142.7ae8aa54@almond.int.arc7.info> Hello! I realize the subject is somewhat convoluted. I'm putting together something that bears a passing resemblance to a DAW such as Ardour: https://rekkerd.org/img/201303/ardour3.png Mine doesn't look like that, but the principle is basically the same: I have regions (the blocks containing waveform images above) placed on a timeline. The timeline is scalable on both axes independently; scaling the timeline vertically gives you more space to work with when adjusting automation curves (visible in the "Fader" lane above), and scaling/translating the timeline horizontally allows you to move forwards and backwards in time, and to focus more clearly on a particular region of time. For the sake of simplicity, let's act as if I have just a single timeline instead of the multiple stacked timelines shown in that image. My application expresses the positions of regions on the timeline in terms of "ticks" (small units of time). For the (obviously JavaFX-based) GUI, I'd like to be able to specify a single transform on the timeline view such that I can specify the coordinates of region nodes in terms of ticks and the transform will determine their onscreen pixel positions appropriately. This isn't too hard to do; I can specify an x-axis scale such that 1 pixel = 128 ticks, and I can then specify an x-axis translation in terms of ticks that will be scaled appropriately for the screen. The problem then, however, is that the the nodes within region nodes are also scaled up hugely; if I try to put labels in the regions, the labels will appear 128 times larger than they normally would. :) I want to specify the *positions* of regions in one coordinate system, but work in ordinary "scene pixels" inside those regions. I can't quite work out how to express the transforms I need to JavaFX. I feel like what I need to do is, for each region node, add *another* node inside the node that fills the region entirely, and specify an inverse of the transform applied to the parent region node... If that makes any sense. Is there a sensible way to do what I'm trying to do? [I've developed a 3D renderer, so I'm familiar with how transforms are concatenated using matrices. I don't have an intuitive understanding of how transforms are applied inside JavaFX, and there doesn't appear to be much documentation on this.] -- Mark Raynsford | http://www.io7m.com From kevin.rushforth at oracle.com Tue Aug 6 20:55:55 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 6 Aug 2019 13:55:55 -0700 Subject: OpenJFX 13 is in Rampdown Phase Two (RDP2) Message-ID: To: OpenJFX Developers As a reminder, OpenJFX 13 is now in Rampdown Phase Two RDP2. [1] During RDP2, all bug fixes (except for docs and test fixes), and all enhancements will need explicit approval to go in to openjfx/13-dev. The bar for approving bug fixes is appropriately high at this point. We do not anticipate approving any more enhancements. We will use the same rules for RDP2 that the JDK uses [2], with three modifications: 1. Approval is needed from one of the OpenJFX project leads (not the OpenJDK project lead) 2. Since we are not part of the JDK, we need to use labels that do not collide with the JDK 13 release. As an obvious choice, derived from the JBS fix version, we will use "openjfx13-fix-request", "openjfx13-fix-yes", "openjfx13-fix-no" and "openjfx13-fix-nmi", "openjfx13-enhancement-request", "openjfx13-enhancement-yes", "openjfx13-enhancement-no" and "openjfx13-enhancement-nmi" as corresponding labels. 3. Some important P3 bugs might be considered during RDP2, as long as those bugs have otherwise met the usual code review criteria. Having said that, most P3 bugs should be moved to openjfx14 at this point. I expect few, if any, P3 bugs to be approved. Note that if a fix is approved to push to 13-dev (with the appropriate approval label added by a lead), then you should? *not* also push it to jfx-dev -- we will auto-sync from 13-dev --> jfx-dev for the duration of the openjfx13 release. Now that we are in RDP2, the goal is to stabilize what is there, with priority on fixing bugs that are new in openjfx13. We need to be extremely careful about including anything that introduces risk. Let me know if there are any questions. -- Kevin [1] https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-March/023180.html [2] http://openjdk.java.net/jeps/3 From kevin.rushforth at oracle.com Tue Aug 6 23:26:50 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 6 Aug 2019 16:26:50 -0700 Subject: Building on windows In-Reply-To: References: Message-ID: <385a17dc-ad64-6157-0324-e7f99249292a@oracle.com> If commenting out those two lines made a difference, then there is likely something wrong with your environment. WINDOWS_VS_VER should only be "100" with Visual Studio 2010. If you have VS 2017 installed in the right place (or are pointing to it), then WINDOWS_VS_VER should be 150. You might want to make sure that it isn't something else (e.g., a stale build or a running gradle daemon). Running "gradle --stop" and then "rm -rf build" often helps resolve these sort of strange problems. -- Kevin On 8/5/2019 5:46 PM, Thiago Milczarek Sayao wrote: > win.gradle line 155: > > > //if (WINDOWS_VS_VER != "100") { > winSdkBinDir += "/$CPU_BITS" > //} > > I have Windows 10, so commenting the if resolved the problem. Wonder why it's there... > ________________________________ > De: Nir Lisker > Enviado: segunda-feira, 5 de agosto de 2019 07:44 > Para: Thiago Milczarek Sayao > Cc: openjfx-dev at openjdk.java.net > Assunto: Re: Building on windows > > The double slash in "Bin//rc.exe" is weird, there should be a folder there. > > If it helps, build.gradle has this comment on line 40: >> The genVSproperties.bat doesn't find the directory where RC.exe lives. So it is hard coded. Might be a problem. > I never hit this problem. > > - Nir > > On Mon, Aug 5, 2019 at 4:26 AM Thiago Milczarek Sayao > wrote: > Managed to get past the error by updating the source tree. > > Now I'm getting this: >> FAIL: cannot find RC: C:/Program Files (x86)/Windows Kits/10/Bin//rc.exe > Seems to be failing to get CPU architecture. > > Mine is x64 (AMD Ryzen). > > Chocolatey gives me the same error. > > Cheers. > ________________________________ > De: openjfx-dev > em nome de Thiago Milczarek Sayao > > Enviado: s?bado, 3 de agosto de 2019 19:41 > Para: openjfx-dev at openjdk.java.net > > Assunto: Building on windows > > Hi, > > I have followed the instructions on: > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows > > When running ./gradlew.bat on cygwin I get: > >> FAIL: WINSDK_DIR not defined > My version is 14.16.27012. > > > Thanks. From guru.hb at oracle.com Thu Aug 8 19:35:59 2019 From: guru.hb at oracle.com (Guru) Date: Fri, 9 Aug 2019 01:05:59 +0530 Subject: RFR: JDK-8229328: [windows] PlatformFileHandle type should be JGObject rather than void * Message-ID: <3D3F0C62-A43B-4A60-B82B-A67B79CB74B9@oracle.com> Hi, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8229328 PR : https://github.com/javafxports/openjdk-jfx/pull/555 Root cause and Solution updated in JBS. Thanks, Guru From johan.vos at gluonhq.com Fri Aug 9 12:16:00 2019 From: johan.vos at gluonhq.com (Johan Vos) Date: Fri, 9 Aug 2019 14:16:00 +0200 Subject: request to backport some issues to 11 Message-ID: Hi Kevin, I request permission to backport the following issues to 11-dev: JDK-8212158 FX: Update copyright year in docs, readme files to 2019 JDK-8218174 Add missing license file for Mesa header files JDK-8219008 Update OpenGL Headers to version 4.6 JDK-8215775 Scrollbars from web pages appear to be absolute, overlapping everything JDK-8220147 Cherry pick GTK WebKit 2.22.7 changes JDK-8218170 Upgrade antlr to version 4.7.2 JDK-8219917 [WebView] Sub-resource integrity check fails on Windows and Linux JDK-8215686 FX build fails using gradle 5 JDK-8217942 Upgrade to libxslt 1.1.33 JDK-8218172 Upgrade gradle to version 5.3 JDK-8219734 [WebView] Get rid of macOS SDK private API usage JDK-8221941 Wrong package declaration for WCTextRunImpl.java in web module JDK-8133841 Full HD video can not be played on standard 1080p screen in portrait mode JDK-8222217 FX build fails on 32-bit Windows after fix for JDK-8133841 JDK-8215894 Provide media support for libav version 58 Thanks, - Johan From kevin.rushforth at oracle.com Fri Aug 9 12:33:59 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 9 Aug 2019 05:33:59 -0700 Subject: request to backport some issues to 11 In-Reply-To: References: Message-ID: That list looks good. As long as they apply cleanly, possibly adjusting the patch for diff context, go ahead and push them without further review. Before you do, you will want to tag the current tip of the repo with "11.0.4+0". -- Kevin On 8/9/2019 5:16 AM, Johan Vos wrote: > Hi Kevin, > > I request permission to backport the following issues to 11-dev: > > JDK-8212158 FX: Update copyright year in docs, readme files to 2019 > JDK-8218174 Add missing license file for Mesa header files > JDK-8219008 Update OpenGL Headers to version 4.6 > JDK-8215775 Scrollbars from web pages appear to be absolute, overlapping > everything > JDK-8220147 Cherry pick GTK WebKit 2.22.7 changes > JDK-8218170 Upgrade antlr to version 4.7.2 > JDK-8219917 [WebView] Sub-resource integrity check fails on Windows and > Linux > JDK-8215686 FX build fails using gradle 5 > JDK-8217942 Upgrade to libxslt 1.1.33 > JDK-8218172 Upgrade gradle to version 5.3 > JDK-8219734 [WebView] Get rid of macOS SDK private API usage > JDK-8221941 Wrong package declaration for WCTextRunImpl.java in web > module > JDK-8133841 Full HD video can not be played on standard 1080p screen in > portrait mode > JDK-8222217 FX build fails on 32-bit Windows after fix for JDK-8133841 > JDK-8215894 Provide media support for libav version 58 > > Thanks, > > - Johan From org.openjdk at io7m.com Sat Aug 10 15:51:56 2019 From: org.openjdk at io7m.com (Mark Raynsford) Date: Sat, 10 Aug 2019 16:51:56 +0100 Subject: Concatenating transforms to scale positions but not objects In-Reply-To: <20190806191142.7ae8aa54@almond.int.arc7.info> References: <20190806191142.7ae8aa54@almond.int.arc7.info> Message-ID: <20190810165156.4ce0fe8e@almond.int.arc7.info> On 2019-08-06T19:11:42 +0100 Mark Raynsford wrote: > Hello! > > I realize the subject is somewhat convoluted. I'm putting together > something that bears a passing resemblance to a DAW such as Ardour: Given the tumbleweeds and sounds of crickets, I'm guessing that I expressed my question rather poorly. Here's what I'm trying to do: I'm trying to set up a pane with a transform such that I can place objects inside that pane using positions that don't correspond to JavaFX "scene pixels". For example, 1024 units in my coordinate system might correspond to 1 "scene pixel" (is there a better name for the units that JavaFX uses?). However: The objects that are *inside* the objects that I add to the pane want to work in "scene pixels" (for example; Labels seem to want to work in pixel positions when rendering text). Here's a GitHub gist that gives a short example of this: https://gist.github.com/io7m/20b071e11da2dcd96896a43fad6df644 I create one container group (actually a Pane) that adds a transform such that 1 unit == 32 pixels. I add objects to this container. Each object I add has an *external* pane with a size and position specified in units, and an *internal* pane that solely exists to invert the scale of the transform of the *external* pane. Inside this *internal* pane, I can add Labels and so on and these all render correctly. I set up bindings between the transforms so that I can effectively scale and pan the scene by adjusting the transform on the group container. However: Something about this setup seems to be confusing something inside JavaFX; the results I'm seeing onscreen don't seem to match what JavaFX believes the bounds of various objects are. This causes visual issues when I try to do things like set borders on objects, and also seems to confuse ScenicView. Here's a shot with the container group selected (looks correct): https://ataxia.io7m.com/2019/08/10/view0.png Here's a shot with the *external* pane of the bottom object selected: https://ataxia.io7m.com/2019/08/10/view1.png Note that, although the object actually renders onscreen as the right size (one of the pale grey boxes), ScenicView seems to believe that the object's bounds are 1x1: They *are* 1x1, but they're 1x1 when expressed in my custom coordinate system, not in JavaFX "scene pixels". Here's a shot with the *internal* pane of the bottom object selected: https://ataxia.io7m.com/2019/08/10/view2.png This looks correct in the sense that the bounds encompass the label and nothing else. Am I doing something wrong here? I can't tell if I'm basically abusing transforms or not. -- Mark Raynsford | http://www.io7m.com From nlisker at gmail.com Sat Aug 10 23:25:02 2019 From: nlisker at gmail.com (Nir Lisker) Date: Sun, 11 Aug 2019 02:25:02 +0300 Subject: Concatenating transforms to scale positions but not objects In-Reply-To: <20190810165156.4ce0fe8e@almond.int.arc7.info> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> Message-ID: I think that this is a better question for StackOverflow. This is a development mailing list. - Nir On Sat, Aug 10, 2019 at 6:53 PM Mark Raynsford wrote: > On 2019-08-06T19:11:42 +0100 > Mark Raynsford wrote: > > > Hello! > > > > I realize the subject is somewhat convoluted. I'm putting together > > something that bears a passing resemblance to a DAW such as Ardour: > > Given the tumbleweeds and sounds of crickets, I'm guessing that I > expressed my question rather poorly. > > Here's what I'm trying to do: I'm trying to set up a pane with a > transform such that I can place objects inside that pane using > positions that don't correspond to JavaFX "scene pixels". For example, > 1024 units in my coordinate system might correspond to 1 "scene pixel" > (is there a better name for the units that JavaFX uses?). However: The > objects that are *inside* the objects that I add to the pane want to > work in "scene pixels" (for example; Labels seem to want to work in > pixel positions when rendering text). > > Here's a GitHub gist that gives a short example of this: > > https://gist.github.com/io7m/20b071e11da2dcd96896a43fad6df644 > > I create one container group (actually a Pane) that adds a transform > such that 1 unit == 32 pixels. I add objects to this container. Each > object I add has an *external* pane with a size and position specified > in units, and an *internal* pane that solely exists to invert the scale > of the transform of the *external* pane. Inside this *internal* pane, I > can add Labels and so on and these all render correctly. > > I set up bindings between the transforms so that I can effectively > scale and pan the scene by adjusting the transform on the group > container. However: Something about this setup seems to be confusing > something inside JavaFX; the results I'm seeing onscreen don't seem to > match what JavaFX believes the bounds of various objects are. This > causes visual issues when I try to do things like set borders on > objects, and also seems to confuse ScenicView. > > Here's a shot with the container group selected (looks correct): > > https://ataxia.io7m.com/2019/08/10/view0.png > > Here's a shot with the *external* pane of the bottom object selected: > > https://ataxia.io7m.com/2019/08/10/view1.png > > Note that, although the object actually renders onscreen as the right > size (one of the pale grey boxes), ScenicView seems to believe that the > object's bounds are 1x1: They *are* 1x1, but they're 1x1 when expressed > in my custom coordinate system, not in JavaFX "scene pixels". > > Here's a shot with the *internal* pane of the bottom object selected: > > https://ataxia.io7m.com/2019/08/10/view2.png > > This looks correct in the sense that the bounds encompass the label and > nothing else. > > Am I doing something wrong here? I can't tell if I'm basically abusing > transforms or not. > > -- > Mark Raynsford | http://www.io7m.com > > From mp at jugs.org Sat Aug 10 23:41:39 2019 From: mp at jugs.org (Michael Paus) Date: Sun, 11 Aug 2019 01:41:39 +0200 Subject: Concatenating transforms to scale positions but not objects In-Reply-To: References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> Message-ID: <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> Nir is right here but if you could ask your question on StackOverflow I'd be willing to comment on it because I was facing a very similar problem in my projects and I might provide some ideas. Am 11.08.19 um 01:25 schrieb Nir Lisker: > I think that this is a better question for StackOverflow. This is a > development mailing list. > > - Nir > > On Sat, Aug 10, 2019 at 6:53 PM Mark Raynsford wrote: > >> On 2019-08-06T19:11:42 +0100 >> Mark Raynsford wrote: >> >>> Hello! >>> >>> I realize the subject is somewhat convoluted. I'm putting together >>> something that bears a passing resemblance to a DAW such as Ardour: >> Given the tumbleweeds and sounds of crickets, I'm guessing that I >> expressed my question rather poorly. >> >> Here's what I'm trying to do: I'm trying to set up a pane with a >> transform such that I can place objects inside that pane using >> positions that don't correspond to JavaFX "scene pixels". For example, >> 1024 units in my coordinate system might correspond to 1 "scene pixel" >> (is there a better name for the units that JavaFX uses?). However: The >> objects that are *inside* the objects that I add to the pane want to >> work in "scene pixels" (for example; Labels seem to want to work in >> pixel positions when rendering text). >> >> Here's a GitHub gist that gives a short example of this: >> >> https://gist.github.com/io7m/20b071e11da2dcd96896a43fad6df644 >> >> I create one container group (actually a Pane) that adds a transform >> such that 1 unit == 32 pixels. I add objects to this container. Each >> object I add has an *external* pane with a size and position specified >> in units, and an *internal* pane that solely exists to invert the scale >> of the transform of the *external* pane. Inside this *internal* pane, I >> can add Labels and so on and these all render correctly. >> >> I set up bindings between the transforms so that I can effectively >> scale and pan the scene by adjusting the transform on the group >> container. However: Something about this setup seems to be confusing >> something inside JavaFX; the results I'm seeing onscreen don't seem to >> match what JavaFX believes the bounds of various objects are. This >> causes visual issues when I try to do things like set borders on >> objects, and also seems to confuse ScenicView. >> >> Here's a shot with the container group selected (looks correct): >> >> https://ataxia.io7m.com/2019/08/10/view0.png >> >> Here's a shot with the *external* pane of the bottom object selected: >> >> https://ataxia.io7m.com/2019/08/10/view1.png >> >> Note that, although the object actually renders onscreen as the right >> size (one of the pale grey boxes), ScenicView seems to believe that the >> object's bounds are 1x1: They *are* 1x1, but they're 1x1 when expressed >> in my custom coordinate system, not in JavaFX "scene pixels". >> >> Here's a shot with the *internal* pane of the bottom object selected: >> >> https://ataxia.io7m.com/2019/08/10/view2.png >> >> This looks correct in the sense that the bounds encompass the label and >> nothing else. >> >> Am I doing something wrong here? I can't tell if I'm basically abusing >> transforms or not. >> >> -- >> Mark Raynsford | http://www.io7m.com >> >> From org.openjdk at io7m.com Sun Aug 11 08:47:22 2019 From: org.openjdk at io7m.com (Mark Raynsford) Date: Sun, 11 Aug 2019 09:47:22 +0100 Subject: Concatenating transforms to scale positions but not objects In-Reply-To: <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> Message-ID: <20190811094722.2de65e8f@almond.int.arc7.info> On 2019-08-11T01:41:39 +0200 Michael Paus wrote: > Nir is right here but if you could ask your question on StackOverflow > I'd be willing to comment on it because I was facing a very similar > problem in my projects and I might provide some ideas. > > Am 11.08.19 um 01:25 schrieb Nir Lisker: > > I think that this is a better question for StackOverflow. This is a > > development mailing list. The Community section on https://openjfx.io points here: "JavaFX features a vibrant and passionate developer community. This enthusiasm can be found in the open source mailing list [link to openjfx-dev]." There's nothing anywhere that I can see that states what kind of discussion is and isn't on topic. I will consider posting on StackOverflow but I've had some bad experiences there in the past (overly-zealous anti-spam mechanisms preventing me linking to references, preventing me from answering my own question, etc). -- Mark Raynsford | http://www.io7m.com From ebresie at gmail.com Sun Aug 11 12:15:41 2019 From: ebresie at gmail.com (Eric Bresie) Date: Sun, 11 Aug 2019 07:15:41 -0500 Subject: Concatenating transforms to scale positions but not objects In-Reply-To: <20190810165156.4ce0fe8e@almond.int.arc7.info> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> Message-ID: <0cc03464-00ae-4498-a22f-79aa04195a49@Erics-iPhone-X> Are you focused on things from a pane/layout perspective here? Maybe some different layout might help. https://openjfx.io/javadoc/11/javafx.graphics/javafx/scene/layout/package-summary.html Or are you looking for some form of ?chart? component to allow lines to be graphed? https://docs.oracle.com/javafx/2/charts/line-chart.htm For others on the list...while I can see this list as more focused on development of openjfx...is there a list for users of openjfx and how to code with it? Eric Bresie Ebresie at gmail.com > On August 10, 2019 at 10:51:56 AM CDT, Mark Raynsford wrote: > On 2019-08-06T19:11:42 +0100 > Mark Raynsford wrote: > > > Hello! > > > > I realize the subject is somewhat convoluted. I'm putting together > > something that bears a passing resemblance to a DAW such as Ardour: > > Given the tumbleweeds and sounds of crickets, I'm guessing that I > expressed my question rather poorly. > > Here's what I'm trying to do: I'm trying to set up a pane with a > transform such that I can place objects inside that pane using > positions that don't correspond to JavaFX "scene pixels". For example, > 1024 units in my coordinate system might correspond to 1 "scene pixel" > (is there a better name for the units that JavaFX uses?). However: The > objects that are *inside* the objects that I add to the pane want to > work in "scene pixels" (for example; Labels seem to want to work in > pixel positions when rendering text). > > Here's a GitHub gist that gives a short example of this: > > https://gist.github.com/io7m/20b071e11da2dcd96896a43fad6df644 > > I create one container group (actually a Pane) that adds a transform > such that 1 unit == 32 pixels. I add objects to this container. Each > object I add has an *external* pane with a size and position specified > in units, and an *internal* pane that solely exists to invert the scale > of the transform of the *external* pane. Inside this *internal* pane, I > can add Labels and so on and these all render correctly. > > I set up bindings between the transforms so that I can effectively > scale and pan the scene by adjusting the transform on the group > container. However: Something about this setup seems to be confusing > something inside JavaFX; the results I'm seeing onscreen don't seem to > match what JavaFX believes the bounds of various objects are. This > causes visual issues when I try to do things like set borders on > objects, and also seems to confuse ScenicView. > > Here's a shot with the container group selected (looks correct): > > https://ataxia.io7m.com/2019/08/10/view0.png > > Here's a shot with the *external* pane of the bottom object selected: > > https://ataxia.io7m.com/2019/08/10/view1.png > > Note that, although the object actually renders onscreen as the right > size (one of the pale grey boxes), ScenicView seems to believe that the > object's bounds are 1x1: They *are* 1x1, but they're 1x1 when expressed > in my custom coordinate system, not in JavaFX "scene pixels". > > Here's a shot with the *internal* pane of the bottom object selected: > > https://ataxia.io7m.com/2019/08/10/view2.png > > This looks correct in the sense that the bounds encompass the label and > nothing else. > > Am I doing something wrong here? I can't tell if I'm basically abusing > transforms or not. > > -- > Mark Raynsford | http://www.io7m.com > From org.openjdk at io7m.com Mon Aug 12 13:25:37 2019 From: org.openjdk at io7m.com (Mark Raynsford) Date: Mon, 12 Aug 2019 14:25:37 +0100 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <20190811094722.2de65e8f@almond.int.arc7.info> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> Message-ID: <20190812142537.11aff83d@almond.int.arc7.info> On 2019-08-11T09:47:22 +0100 Mark Raynsford wrote: > On 2019-08-11T01:41:39 +0200 > Michael Paus wrote: > > > Nir is right here but if you could ask your question on StackOverflow > > I'd be willing to comment on it because I was facing a very similar > > problem in my projects and I might provide some ideas. Hello! Here's the StackOverflow question: https://stackoverflow.com/questions/57461988/using-an-alternate-coordinate-system-inside-a-pane-or-region Out of interest: Is there any interest in setting up a Gitter.im chat room? Given that there apparently isn't a mailing list for user questions, and that there _is_ a GitHub presence for OpenJFX, a Gitter.im chat room would appear to be the logical place for user discussions. I'd be happy to set up and run such a thing. I find Gitter strikes a fairly nice balance in that it's accessible if you already have a GitHub account, it stores a persistent searchable history like a mailing list, but it's also capable of real-time communication if needed, and is accessible without needing any kind of proprietary client. I'm not sure if there's any other service that ticks all of those boxes. I'm open to suggestions, though. -- Mark Raynsford | http://www.io7m.com From org.openjdk at io7m.com Mon Aug 12 13:29:27 2019 From: org.openjdk at io7m.com (Mark Raynsford) Date: Mon, 12 Aug 2019 14:29:27 +0100 Subject: Concatenating transforms to scale positions but not objects In-Reply-To: <0cc03464-00ae-4498-a22f-79aa04195a49@Erics-iPhone-X> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <0cc03464-00ae-4498-a22f-79aa04195a49@Erics-iPhone-X> Message-ID: <20190812142927.723e1472@almond.int.arc7.info> On 2019-08-11T07:15:41 -0500 Eric Bresie wrote: > Are you focused on things from a pane/layout perspective here? Maybe some different layout might help. > > https://openjfx.io/javadoc/11/javafx.graphics/javafx/scene/layout/package-summary.html > > Or are you looking for some form of ?chart? component to allow lines to be graphed? > > https://docs.oracle.com/javafx/2/charts/line-chart.htm > Unfortunately: Both :) Thankfully, though, the two problems are solvable separately and I only need to focus on the first problem (the pane/layout). I need to position objects in a pane, but I do also need to draw a scrollable grid inside that pane. The issue with using the Chart API to draw graph lines is that I think it assumes that graph tick lines on both axes will always have the same spacing. Unfortunately, given the nature of music (with changing time signatures at different points within pieces of music), the spacing between graph tick lines can change at different points on the timeline. Thankfully, I've already written a custom canvas-based component to deal with this. -- Mark Raynsford | http://www.io7m.com From johan.vos at gluonhq.com Mon Aug 12 15:43:48 2019 From: johan.vos at gluonhq.com (Johan Vos) Date: Mon, 12 Aug 2019 17:43:48 +0200 Subject: RFR: [JDK-8229418] Set release version to 11.0.4 Message-ID: Hi Kevin, Please review https://bugs.openjdk.java.net/browse/JDK-8229418 which bumps the version in the 11-dev tree. Thanks, - Johan From kevin.rushforth at oracle.com Mon Aug 12 15:46:14 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 12 Aug 2019 08:46:14 -0700 Subject: RFR: [JDK-8229418] Set release version to 11.0.4 In-Reply-To: References: Message-ID: Looks good. +1 -- Kevin On 8/12/2019 8:43 AM, Johan Vos wrote: > Hi Kevin, > > Please review https://bugs.openjdk.java.net/browse/JDK-8229418 which bumps > the version in the 11-dev tree. > > Thanks, > > - Johan From org.openjdk at io7m.com Tue Aug 13 10:34:32 2019 From: org.openjdk at io7m.com (Mark Raynsford) Date: Tue, 13 Aug 2019 11:34:32 +0100 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <20190812142537.11aff83d@almond.int.arc7.info> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> <20190812142537.11aff83d@almond.int.arc7.info> Message-ID: <20190813113432.2f8a9812@almond.int.arc7.info> On 2019-08-12T14:25:37 +0100 Mark Raynsford wrote: > > Hello! > > Here's the StackOverflow question: > > https://stackoverflow.com/questions/57461988/using-an-alternate-coordinate-system-inside-a-pane-or-region And, right on cue, the question has been marked as "off-topic". I don't believe that StackOverflow is suitable for general community support. At least half of the interactions I have had with it have ended similarly. Thanks, Michael, for attempting to respond on StackOverflow. Unfortunately, the somewhat rabid moderators have decided that my question isn't worth asking and that your response isn't worth listening to. Sadness. -- Mark Raynsford | http://www.io7m.com From johnvalrose at gmail.com Tue Aug 13 10:43:38 2019 From: johnvalrose at gmail.com (John-Val Rose) Date: Tue, 13 Aug 2019 20:43:38 +1000 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <20190813113432.2f8a9812@almond.int.arc7.info> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> <20190812142537.11aff83d@almond.int.arc7.info> <20190813113432.2f8a9812@almond.int.arc7.info> Message-ID: <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> I?ve all but given up on StackOverflow. It seems to be a haven for trolls or control freaks who deem perfectly reasonable questions as off-topic or inappropriate whereby the question then gets put on hold and can?t be answered. It?s ridiculous and makes the forum almost unusable. Some people enjoy the power they have to make this happen and have no interest in helping you or assisting in having your question answered. Sad. > On 13 Aug 2019, at 20:34, Mark Raynsford wrote: > > On 2019-08-12T14:25:37 +0100 > Mark Raynsford wrote: >> >> Hello! >> >> Here's the StackOverflow question: >> >> https://stackoverflow.com/questions/57461988/using-an-alternate-coordinate-system-inside-a-pane-or-region > > And, right on cue, the question has been marked as "off-topic". > > I don't believe that StackOverflow is suitable for general community > support. At least half of the interactions I have had with it have ended > similarly. > > Thanks, Michael, for attempting to respond on StackOverflow. > Unfortunately, the somewhat rabid moderators have decided that my > question isn't worth asking and that your response isn't worth > listening to. Sadness. > > -- > Mark Raynsford | http://www.io7m.com > From johan at lodgon.com Tue Aug 13 11:07:37 2019 From: johan at lodgon.com (Johan Vos) Date: Tue, 13 Aug 2019 13:07:37 +0200 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> <20190812142537.11aff83d@almond.int.arc7.info> <20190813113432.2f8a9812@almond.int.arc7.info> <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> Message-ID: This is an interesting discussion. I think we should move it to openjfx-discuss, and come to a conclusion there. I started a thread for this: https://mail.openjdk.java.net/pipermail/openjfx-discuss/2019-August/000136.html - Johan Op di 13 aug. 2019 om 12:55 schreef John-Val Rose : > I?ve all but given up on StackOverflow. > > It seems to be a haven for trolls or control freaks who deem perfectly > reasonable questions as off-topic or inappropriate whereby the question > then gets put on hold and can?t be answered. > > It?s ridiculous and makes the forum almost unusable. > > Some people enjoy the power they have to make this happen and have no > interest in helping you or assisting in having your question answered. > > Sad. > > > On 13 Aug 2019, at 20:34, Mark Raynsford wrote: > > > > On 2019-08-12T14:25:37 +0100 > > Mark Raynsford wrote: > >> > >> Hello! > >> > >> Here's the StackOverflow question: > >> > >> > https://stackoverflow.com/questions/57461988/using-an-alternate-coordinate-system-inside-a-pane-or-region > > > > And, right on cue, the question has been marked as "off-topic". > > > > I don't believe that StackOverflow is suitable for general community > > support. At least half of the interactions I have had with it have ended > > similarly. > > > > Thanks, Michael, for attempting to respond on StackOverflow. > > Unfortunately, the somewhat rabid moderators have decided that my > > question isn't worth asking and that your response isn't worth > > listening to. Sadness. > > > > -- > > Mark Raynsford | http://www.io7m.com > > > From johan.vos at gluonhq.com Tue Aug 13 11:41:29 2019 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 13 Aug 2019 13:41:29 +0200 Subject: request to backport JDK-8209967 to jfx-11 Message-ID: Hi Kevin, I request permission to backport the following issue to 11-dev: JDK-8209967 Bump minimum gradle version to 4.8 for JDK 11 Thanks, - Johan From ebresie at gmail.com Tue Aug 13 11:49:18 2019 From: ebresie at gmail.com (Eric Bresie) Date: Tue, 13 Aug 2019 06:49:18 -0500 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> <20190812142537.11aff83d@almond.int.arc7.info> <20190813113432.2f8a9812@almond.int.arc7.info> <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> Message-ID: They don?t appear to be rejecting it per say...It sounds like they just want clear and concise question with code snippets (apparently not a link to the code) added and what the desired behavior is. Eric Bresie Ebresie at gmail.com > On August 13, 2019 at 5:43:38 AM CDT, John-Val Rose wrote: > I?ve all but given up on StackOverflow. > > It seems to be a haven for trolls or control freaks who deem perfectly reasonable questions as off-topic or inappropriate whereby the question then gets put on hold and can?t be answered. > > It?s ridiculous and makes the forum almost unusable. > > Some people enjoy the power they have to make this happen and have no interest in helping you or assisting in having your question answered. > > Sad. > > > On 13 Aug 2019, at 20:34, Mark Raynsford wrote: > > > > On 2019-08-12T14:25:37 +0100 > > Mark Raynsford wrote: > > > > > > Hello! > > > > > > Here's the StackOverflow question: > > > > > > https://stackoverflow.com/questions/57461988/using-an-alternate-coordinate-system-inside-a-pane-or-region > > > > And, right on cue, the question has been marked as "off-topic". > > > > I don't believe that StackOverflow is suitable for general community > > support. At least half of the interactions I have had with it have ended > > similarly. > > > > Thanks, Michael, for attempting to respond on StackOverflow. > > Unfortunately, the somewhat rabid moderators have decided that my > > question isn't worth asking and that your response isn't worth > > listening to. Sadness. > > > > -- > > Mark Raynsford | http://www.io7m.com > > From kevin.rushforth at oracle.com Tue Aug 13 11:54:38 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 13 Aug 2019 04:54:38 -0700 Subject: request to backport JDK-8209967 to jfx-11 In-Reply-To: References: Message-ID: <63eb6a0a-6f2d-8e8a-af17-7cc483720eb9@oracle.com> +1 -- Kevin On 8/13/2019 4:41 AM, Johan Vos wrote: > Hi Kevin, > > I request permission to backport the following issue to 11-dev: > > JDK-8209967 Bump minimum gradle version to 4.8 for JDK 11 > > Thanks, > > - Johan From johan.vos at gluonhq.com Tue Aug 13 15:21:36 2019 From: johan.vos at gluonhq.com (Johan Vos) Date: Tue, 13 Aug 2019 17:21:36 +0200 Subject: RFR: JDK-8229482 : typo in release notes link Message-ID: Please review the (trivial) webrev for https://bugs.openjdk.java.net/browse/JDK-8229482 Thanks, - Johan (since it is in the 12-dev repository, I want to push this to openjdk.net first and then sync to the jfx-12 branch on github) From kevin.rushforth at oracle.com Tue Aug 13 15:24:16 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 13 Aug 2019 08:24:16 -0700 Subject: RFR: JDK-8229482 : typo in release notes link In-Reply-To: References: Message-ID: +1 On 8/13/2019 8:21 AM, Johan Vos wrote: > Please review the (trivial) webrev for > https://bugs.openjdk.java.net/browse/JDK-8229482 > > Thanks, > > - Johan > > (since it is in the 12-dev repository, I want to push this to openjdk.net > first and then sync to the jfx-12 branch on github) From fastegal at swingempire.de Tue Aug 13 15:29:38 2019 From: fastegal at swingempire.de (fastegal at swingempire.de) Date: Tue, 13 Aug 2019 17:29:38 +0200 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> <20190812142537.11aff83d@almond.int.arc7.info> <20190813113432.2f8a9812@almond.int.arc7.info> <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> Message-ID: <20190813172938.Horde.ojpmwuI4HO_SjMtclMsnKg1@webmail.df.eu> Zitat von John-Val Rose : > I?ve all but given up on StackOverflow. > > It seems to be a haven for trolls or control freaks who deem > perfectly reasonable questions as off-topic or inappropriate whereby > the question then gets put on hold and can?t be answered. > > It?s ridiculous and makes the forum almost unusable. > > Some people enjoy the power they have to make this happen and have > no interest in helping you or assisting in having your question > answered. > > Sad. > wow - what an attitude, that's extremely sad :( Did it never occur to you that users of both SO and this mailing list overlap? Please refrain from insulting hard-working members of the community! Jeanette From kustaa.nyholm at sparetimelabs.com Tue Aug 13 16:44:22 2019 From: kustaa.nyholm at sparetimelabs.com (Kustaa Nyholm) Date: Tue, 13 Aug 2019 19:44:22 +0300 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <20190813172938.Horde.ojpmwuI4HO_SjMtclMsnKg1@webmail.df.eu> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> <20190812142537.11aff83d@almond.int.arc7.info> <20190813113432.2f8a9812@almond.int.arc7.info> <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> <20190813172938.Horde.ojpmwuI4HO_SjMtclMsnKg1@webmail.df.eu> Message-ID: > On 13 Aug 2019, at 18.29, fastegal at swingempire.de wrote: > > wow - what an attitude, that's extremely sad :( Did it never occur to you that users of both SO and this mailing list overlap? > > Please refrain from insulting hard-working members of the community! > > Jeanette > > Jeanette I have to say I share more or less John's view of some the members of the SO community. And I don't think saying what John said or saying that I share a lot of that view is insulting. Or did you miss interpret what he wrote? He was talking about the overzealous control freaks at the SO (and many other forums) where perfectly valid and of general interested questions are exterminated at whim. Seen that, been the victim of. wbr Kusti From mp at jugs.org Tue Aug 20 10:59:06 2019 From: mp at jugs.org (Michael Paus) Date: Tue, 20 Aug 2019 12:59:06 +0200 Subject: RFR: JDK-8229890 WritableImage update fails for empty region Message-ID: Hi, please review my fix for JDK-8229890. https://github.com/javafxports/openjdk-jfx/issues/567 https://github.com/javafxports/openjdk-jfx/pull/568 Michael From kevin.rushforth at oracle.com Tue Aug 20 22:14:24 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 20 Aug 2019 15:14:24 -0700 Subject: Proposal: Migrate official jfx repo to GitHub + Skara tooling Message-ID: To: OpenJFX Contributors, As most of you are aware, Project Skara is moving forward with a proposed JEP [1] to migrate various OpenJDK projects to git, likely hosted on GitHub. A read-only git mirror of the HG openjfx/jfx-dev/rt repo [2] is available on GitHub at openjdk/jfx [3]. Similarly, there is a read-only mirror of the jdk/jdk repo [4] as well. We've been talking with the Skara team about having OpenJFX be one of the "early adopters" in the git transition. Since a large percentage of the JavaFX code reviews are already happening on GitHub as pull requests against the javafxports/openjdk-jfx (sandbox) mirror, the OpenJFX project would be a natural fit for this. For contributors who are not Committers, there won't be many differences, other than some of the steps will go away (e.g., the Skara tooling will automate the RFR email). For Committers, there will be some minor differences, primarily around eliminating steps -- no more need to merge the pull request into "develop", export the patch, import it into a Mercurial repo, and push it to the official HG repo. Instead, you will use the "/integrate" command as a PR comment to merge the pull request, and then you are done. You will still need to update JBS, at least initially, to resolve the bug as fixed and add the URL to the commit, but even that will be automated at some point. Developers who are interested in leaning more about the Skara tools and workflow can find information on the Skara Wiki [5], GitHub project [6], and mailing list [7]. I note that using the Skara client-side tools on your desktop is completely optional. I expect many (most?) developers will use the GitHub workflow they are already used to via the web interface, but there is an option for those who want to use the command line tools like "git pr". As a final note, I recommend waiting to create a personal fork of the openjdk/jfx mirror, since the Skara team is going to re-convert all openjdk/* mirrors in a couple days [8], and you will just end up having to delete and refork. Comments on this proposal are welcome. -- Kevin [1] https://openjdk.java.net/jeps/357 [2] http://hg.openjdk.java.net/openjfx/jfx-dev/rt [3] https://github.com/openjdk/jfx [4] https://github.com/openjdk/jdk [5] https://wiki.openjdk.java.net/display/skara [6] https://github.com/openjdk/skara [7] https://mail.openjdk.java.net/mailman/listinfo/skara-dev [8] https://mail.openjdk.java.net/pipermail/skara-dev/2019-August/000327.html From kevin.rushforth at oracle.com Tue Aug 20 22:39:27 2019 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 20 Aug 2019 15:39:27 -0700 Subject: List of OpenJFX Reviewers now in OpenJDK Census Message-ID: For the past year, we have had a list of reviewers on the Code Review Policy [1] WIki page, along with the following comment: ??? "We might decide in the future to use the formal OpenJDK Reviewer role. If so, then the above list will be replaced by a pointer to the census at that time. The intention, though, is that this list of Reviewers be functionally equivalent to the OpenJDK Reviewer role." In preparation for the proposed move to GitHub using the Skara tooling, we have formalized this by recording the list of OpenJFX Project Reviewers [3] on the OpenJDK Census. The Skara tooling relies on the OpenJDK Census to know who is a Reviewer in order to check that a proposed fix (pull request) has been reviewed. -- Kevin [1] https://wiki.openjdk.java.net/pages/viewpage.action?pageId=49250438#CodeReviews-ReviewersTableListofReviewers [2] https://openjdk.java.net/census#openjfx From mp at jugs.org Tue Aug 20 22:58:04 2019 From: mp at jugs.org (Michael Paus) Date: Wed, 21 Aug 2019 00:58:04 +0200 Subject: Proposal: Migrate official jfx repo to GitHub + Skara tooling In-Reply-To: References: Message-ID: Hi Am 21.08.19 um 00:14 schrieb Kevin Rushforth: > I expect many (most?) developers will use the GitHub workflow they are > already used to via the web interface, but there is an option for > those who want to use the command line tools like "git pr". I just wanted to add that there is even a third option which is GitHub-Desktop. https://desktop.github.com/ A standalone application from GitHub which simplifies some of the work. (A pitty it is written in Electron and not in JavaFX ;-)) Michael From r.lichtenberger at gmail.com Wed Aug 21 12:16:32 2019 From: r.lichtenberger at gmail.com (Robert Lichtenberger) Date: Wed, 21 Aug 2019 14:16:32 +0200 Subject: Proposal: Migrate official jfx repo to GitHub + Skara tooling In-Reply-To: References: Message-ID: <381c37a2-ac0f-1fd0-b714-b1d2dac56440@gmail.com> Am 21.08.19 um 00:14 schrieb Kevin Rushforth: > Comments on this proposal are welcome. Best news I've had this week ;-). I appreciate and support this proposal, it will make contributing much easier, especially for people like me who contribute only occasionally. From pererik.svensson at gmail.com Fri Aug 23 08:52:24 2019 From: pererik.svensson at gmail.com (Per-Erik Svensson) Date: Fri, 23 Aug 2019 10:52:24 +0200 Subject: JDK-8230007 Message-ID: Hi, First of all, sorry if this is not the place but I've been trying to find a way to comment on a bug that I reported a few days ago, since Kevin Rushforth has commented on it in a way that makes me believe that the bug may receive a harder than needed triage and that you (possibly) will spend unnecessary time looking for a solution. So this is my attempt at reaching the devs. Secondly, I think a P4 priority is fine, it's probably not a common bug, nothing crashes and I've found a workable workaround (see below). As the report states, this has nothing to do with the use of Robot. We get this error without using either AWT Robot or JFX Robot. The reason Robot is used is so that I could send a minimal amount of code showing the problem without having to make further instructions about resizing, how many pixels and so on. Just a couple lines of code to force the bug to show on screen. If you resize manually, one needs a fairly steady hand to see the bug as more than a flickering. So I wanted the code to show that the skewed rendering is persistent at certain pixels, not just a flickering that corrects itself. You may remove the entire loadWorker-listener and the bug will still be reproducible always, but then you need to manually resize the JFrame (with a steady hand to hit the correct pixels and release the mouse button without moving the mouse away from that position). It's not hard to do manually, just harder than to show the bug programmatically. (As an aside: Kevin Rushforth's comment hints at it being more natural to use AWT Robot in a JFrame. This is true but I needed to wait for the WebEngine to load the site before resizing the window so it made more sense to me to use JFX's Robot since I was on the JFX-thread.) Any way, the bug is reproducible without Robots of any kind so the bug is either a problem with JFXPanel or JavaFX/Swing/AWT's HiDPI support or more likely, that the HiDPI support of the different frameworks don't play nice with each other. The following workaround may give more insight. If the JFXPanel's setBounds(int,int,int,int) is overriden with code to "skip" every pixel resize that, when multiplied with the DPI-scaling of the screen, results in a number that ends with .25 or .75, everything works without a skewed rendering. This obviously means that the JFXPanel will sometimes be smaller than it should be and thus not rendering all the way out to the parent's bounds, but that is a tradeoff I'm willing to make. A few missed pixels on high resolution monitors isn't as eye jarring as a 45 degree x-shearing of the entire rendering surface. Here is example code to show how the "skipping" is done: JFXPanel jfx = new JFXPanel() { private int skipPixels(int number, double scale) { double scaled = number * scale; while((scaled - Math.floor(scaled) == 0.25) || (scaled - Math.floor(scaled) == 0.75)) { number--; scaled = number * scale; } return number; } @Override public void setBounds(int x, int y, int width, int height) { double scaleX = getGraphicsConfiguration().getDefaultTransform().getScaleX(); double scaleY = getGraphicsConfiguration().getDefaultTransform().getScaleX(); int w = skipPixels(width, scaleX); int h = skipPixels(height, scaleY); super.setBounds(x, y, w, h); } }; Finally, I must say I'm impressed with how you handle bugs from the web form. Thanks for that! Best Regards Per-Erik Svensson From amnojeeuw at gmail.com Sat Aug 24 21:15:01 2019 From: amnojeeuw at gmail.com (AmnoJeeuw) Date: Sat, 24 Aug 2019 17:15:01 -0400 Subject: Gitter chat + StackOverflow [was: Concatenating transforms to scale positions but not objects] In-Reply-To: <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> References: <20190806191142.7ae8aa54@almond.int.arc7.info> <20190810165156.4ce0fe8e@almond.int.arc7.info> <2504561f-a276-cd57-ec80-023afc452f8f@jugs.org> <20190811094722.2de65e8f@almond.int.arc7.info> <20190812142537.11aff83d@almond.int.arc7.info> <20190813113432.2f8a9812@almond.int.arc7.info> <1EE3A8C7-508B-4432-AC7F-7D7C84DEDFC4@gmail.com> Message-ID: Most people I know have given up StackOverflow. I, myself, have not posted a question for a very long time. On 2019-08-13 6:43 a.m., John-Val Rose wrote: > I?ve all but given up on StackOverflow. > > It seems to be a haven for trolls or control freaks who deem perfectly reasonable questions as off-topic or inappropriate whereby the question then gets put on hold and can?t be answered. > > It?s ridiculous and makes the forum almost unusable. > > Some people enjoy the power they have to make this happen and have no interest in helping you or assisting in having your question answered. > > Sad. > >> On 13 Aug 2019, at 20:34, Mark Raynsford wrote: >> >> On 2019-08-12T14:25:37 +0100 >> Mark Raynsford wrote: >>> Hello! >>> >>> Here's the StackOverflow question: >>> >>> https://stackoverflow.com/questions/57461988/using-an-alternate-coordinate-system-inside-a-pane-or-region >> And, right on cue, the question has been marked as "off-topic". >> >> I don't believe that StackOverflow is suitable for general community >> support. At least half of the interactions I have had with it have ended >> similarly. >> >> Thanks, Michael, for attempting to respond on StackOverflow. >> Unfortunately, the somewhat rabid moderators have decided that my >> question isn't worth asking and that your response isn't worth >> listening to. Sadness. >> >> -- >> Mark Raynsford | http://www.io7m.com >> --- This email has been checked for viruses by AVG. https://www.avg.com From t.rauchhaupt at googlemail.com Mon Aug 26 06:46:14 2019 From: t.rauchhaupt at googlemail.com (Thimo von Rauchhaupt) Date: Mon, 26 Aug 2019 08:46:14 +0200 Subject: JDK-8230007 In-Reply-To: References: Message-ID: Hi, I'm quite in a rush and not in the office for a time, so I cannot analyze or write more. It seems quite the same problem we have already filed under https://bugs.openjdk.java.net/browse/JDK-8220484 . Best regards, Thimo Per-Erik Svensson schrieb am Fr., 23. Aug. 2019, 10:52: > Hi, > > First of all, sorry if this is not the place but I've been trying to find a > way to comment on a bug that I reported a few days ago, since Kevin > Rushforth has commented on it in a way that makes me believe that the bug > may receive a harder than needed triage and that you (possibly) will spend > unnecessary time looking for a solution. So this is my attempt at reaching > the devs. > > Secondly, I think a P4 priority is fine, it's probably not a common bug, > nothing crashes and I've found a workable workaround (see below). > > As the report states, this has nothing to do with the use of Robot. We get > this error without using either AWT Robot or JFX Robot. The reason Robot is > used is so that I could send a minimal amount of code showing the problem > without having to make further instructions about resizing, how many pixels > and so on. Just a couple lines of code to force the bug to show on screen. > If you resize manually, one needs a fairly steady hand to see the bug as > more than a flickering. So I wanted the code to show that the skewed > rendering is persistent at certain pixels, not just a flickering that > corrects itself. > > You may remove the entire loadWorker-listener and the bug will still be > reproducible always, but then you need to manually resize the JFrame (with > a steady hand to hit the correct pixels and release the mouse button > without moving the mouse away from that position). It's not hard to do > manually, just harder than to show the bug programmatically. > > (As an aside: Kevin Rushforth's comment hints at it being more natural to > use AWT Robot in a JFrame. This is true but I needed to wait for the > WebEngine to load the site before resizing the window so it made more sense > to me to use JFX's Robot since I was on the JFX-thread.) > > Any way, the bug is reproducible without Robots of any kind so the bug is > either a problem with JFXPanel or JavaFX/Swing/AWT's HiDPI support or more > likely, that the HiDPI support of the different frameworks don't play nice > with each other. The following workaround may give more insight. > > If the JFXPanel's setBounds(int,int,int,int) is overriden with code to > "skip" every pixel resize that, when multiplied with the DPI-scaling of the > screen, results in a number that ends with .25 or .75, everything works > without a skewed rendering. This obviously means that the JFXPanel will > sometimes be smaller than it should be and thus not rendering all the way > out to the parent's bounds, but that is a tradeoff I'm willing to make. A > few missed pixels on high resolution monitors isn't as eye jarring as a 45 > degree x-shearing of the entire rendering surface. > > Here is example code to show how the "skipping" is done: > > JFXPanel jfx = new JFXPanel() { > private int skipPixels(int number, double scale) { > double scaled = number * scale; > while((scaled - Math.floor(scaled) == 0.25) || (scaled - > Math.floor(scaled) == 0.75)) { > number--; > scaled = number * scale; > } > return number; > } > > @Override > public void setBounds(int x, int y, int width, int height) { > double scaleX = > getGraphicsConfiguration().getDefaultTransform().getScaleX(); > double scaleY = > getGraphicsConfiguration().getDefaultTransform().getScaleX(); > int w = skipPixels(width, scaleX); > int h = skipPixels(height, scaleY); > super.setBounds(x, y, w, h); > } > }; > > > Finally, I must say I'm impressed with how you handle bugs from the web > form. Thanks for that! > > Best Regards > Per-Erik Svensson > > From sverre.moe at gmail.com Mon Aug 26 18:03:22 2019 From: sverre.moe at gmail.com (Sverre Moe) Date: Mon, 26 Aug 2019 20:03:22 +0200 Subject: Bug in TreeTableView rendering Message-ID: I think I have found a bug/regression with Java 11 regarding TreeTableView. This has worked fine on JavaFX 8, but is messed up with JavaFX 11. 1) The arrow button is on the text 2) No text indentation levels: Each row (no matter the level) is at the left edge of the TreeTableView. I can file an issue at GitHub if this is a real bug/regression. I just wanted to check first here. TreeTableColumn column = new TreeTableColumn<>("Column"); column.setCellValueFactory(param -> new ReadOnlyObjectWrapper<>(new OurDataObjectLabel(param.getValue().getValue()))); We are using Label here so we can set StyleClass based on some information in the OurDataObject. class OurDataObject { private String name; public String getName() { return name; } } class AlsoOurDataObject extends OurDataObject { public boolean isSomething() { ... } } class OurDataObjectLabel extends Label() { public OurDataObjectLabel(OurDataObject ourDataObject) { setText(ourDataObject.getName()); if (ourDataObject instanceof AlsoOurDataObject) { if (((AlsoOurDataObject) ourDataObject).isSomething()) { getStyleClass().add("style"); } } } } A workaround was to use OurDataObject for both types in the TreeTableColumn, create a CellFactory to do what has been done in OurDataObjectLabel and in addition to the CellValueFactory. Code Example for reproducing the problem: This is using a String instead of an Object as the data model for simplicity. I have attached a screenshot that illustrates this problem. Made with the example code below. import javafx.application.Application; import javafx.beans.property.ReadOnlyObjectWrapper; import javafx.scene.Scene; import javafx.scene.control.TreeItem; import javafx.scene.control.TreeTableColumn; import javafx.scene.control.TreeTableView; import javafx.scene.layout.StackPane; import javafx.scene.text.Text; import javafx.stage.Stage; public class App extends Application { public static void main(String[] args) { App.launch(args); } @Override public void start(Stage stage) throws Exception { StackPane root = new StackPane(); TreeTableView treeTableView = new TreeTableView<>(); treeTableView.setShowRoot(false); root.getChildren().add(treeTableView); TreeTableColumn column = new TreeTableColumn<>("Column"); column.setPrefWidth(200); treeTableView.getColumns().add(column); column.setCellValueFactory(param -> new ReadOnlyObjectWrapper<>( new Text(param.getValue().getValue()))); TreeItem rootItem = new TreeItem<>(""); treeTableView.setRoot(rootItem); TreeItem item1 = new TreeItem<>("LEVEL1"); item1.setExpanded(true); rootItem.getChildren().add(item1); TreeItem item2 = new TreeItem<>("LEVEL2"); item2.setExpanded(true); item1.getChildren().add(item2); TreeItem item3 = new TreeItem<>("LEVEL2_1"); item3.setExpanded(true); item2.getChildren().add(item3); Scene scene = new Scene(root, 250, 150); stage.setTitle("JavaFX11"); stage.setScene(scene); stage.show(); } } /Sverre From guru.hb at oracle.com Thu Aug 29 20:05:47 2019 From: guru.hb at oracle.com (Guru) Date: Fri, 30 Aug 2019 01:35:47 +0530 Subject: RFR: JDK-8230361: [web] Cookies are not enabled in 608.1 Message-ID: <6F3A3124-206F-4218-9BFC-86925A3DDBA3@oracle.com> Hi, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8230361 PR : https://github.com/javafxports/openjdk-jfx/pull/576 Thanks, Guru From fastegal at swingempire.de Fri Aug 30 08:03:39 2019 From: fastegal at swingempire.de (Jeanette Winzenburg) Date: Fri, 30 Aug 2019 10:03:39 +0200 Subject: RFR: JDK-8207774: TextField must not forward ENTER if action consumed Message-ID: <20190830100339.Horde.26ivHd3wu-9Jrk7YKSB0xw8@webmail.df.eu> Please review the fix for bug: JBS: https://bugs.openjdk.java.net/browse/JDK-8207774 openjfx: https://github.com/javafxports/openjdk-jfx/pull/575 Thanks, Jeanette From jfm0555 at gmail.com Fri Aug 23 01:19:32 2019 From: jfm0555 at gmail.com (J-F M.) Date: Fri, 23 Aug 2019 01:19:32 -0000 Subject: mmap crash all jvm Message-ID: Hi, when webview open php_manual_en.html with: virtual box 6.0.10 libc6 2.24-11+deb9u4 openjdk 12.0.1+12 2019-04-16 openjdk 12.0.2 openjdk 14 beter but crash on reload. javafx-sdk-12.0.1 javafx-sdk-12.0.2 kernel 4.19 kernel 5 with vm.max_map_count=200072 libjfxwebkit.so bmalloc crash all my jvm no problem on win 10 Best Regards, Jean-Fran?ois Martel