Building on windows

[Kevin Rushforth]

If commenting out those two lines made a difference, then there is 
likely something wrong with your environment. WINDOWS_VS_VER should only 
be "100" with Visual Studio 2010. If you have VS 2017 installed in the 
right place (or are pointing to it), then WINDOWS_VS_VER should be 150.

You might want to make sure that it isn't something else (e.g., a stale 
build or a running gradle daemon). Running "gradle --stop" and then "rm 
-rf build" often helps resolve these sort of strange problems.

-- Kevin

On 8/5/2019 5:46 PM, Thiago Milczarek Sayao wrote:
> win.gradle line 155:
>
>
> //if (WINDOWS_VS_VER != "100") {
>      winSdkBinDir += "/$CPU_BITS"
> //}
>
> I have Windows 10, so commenting the if resolved the problem. Wonder why it's there...
> ________________________________
> De: Nir Lisker <nlisker at gmail.com>
> Enviado: segunda-feira, 5 de agosto de 2019 07:44
> Para: Thiago Milczarek Sayao <thiago.sayao at clamed.com.br>
> Cc: openjfx-dev at openjdk.java.net <openjfx-dev at openjdk.java.net>
> Assunto: Re: Building on windows
>
> The double slash in "Bin//rc.exe" is weird, there should be a folder there.
>
> If it helps, build.gradle has this comment on line 40:
>> The genVSproperties.bat doesn't find the directory where RC.exe lives. So it is hard coded. Might be a problem.
> I never hit this problem.
>
> - Nir
>
> On Mon, Aug 5, 2019 at 4:26 AM Thiago Milczarek Sayao <thiago.sayao at clamed.com.br<mailto:thiago.sayao at clamed.com.br>> wrote:
> Managed to get past the error by updating the source tree.
>
> Now I'm getting this:
>> FAIL: cannot find RC: C:/Program Files (x86)/Windows Kits/10/Bin//rc.exe
> Seems to be failing to get CPU architecture.
>
> Mine is x64 (AMD Ryzen).
>
> Chocolatey gives me the same error.
>
> Cheers.
> ________________________________
> De: openjfx-dev <openjfx-dev-bounces at openjdk.java.net<mailto:openjfx-dev-bounces at openjdk.java.net>> em nome de Thiago Milczarek Sayao <thiago.sayao at clamed.com.br<mailto:thiago.sayao at clamed.com.br>>
> Enviado: sábado, 3 de agosto de 2019 19:41
> Para: openjfx-dev at openjdk.java.net<mailto:openjfx-dev at openjdk.java.net> <openjfx-dev at openjdk.java.net<mailto:openjfx-dev at openjdk.java.net>>
> Assunto: Building on windows
>
> Hi,
>
> I have followed the instructions on:
> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows
>
> When running ./gradlew.bat on cygwin I get:
>
>> FAIL: WINSDK_DIR not defined
> My version is 14.16.27012.
>
>
> Thanks.