[Approved] RFR: 8235151: Inexistent notifyQuit method referred from iOS GlassHelper.m

Johan Vos jvos at openjdk.java.net
Sun Dec 1 16:32:41 UTC 2019


On Sat, 30 Nov 2019 22:31:29 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

> `GlassHelper.m` for iOS contains the public method `ApplicationNotifyQuitMethod()`, that tries to find via reflection the `notifyQuit()` method in the `com.sun.glass.ui.Application` class. 
> 
> But the method `notifyQuit` doesn't exist in that class. However `notifyWillQuit` exists, and it is used in the Mac platform, for instance, when `ApplicationNotifyWillQuitMethod()` is called.
> 
> This PR renames `notifyQuit` to `notifyWillQuit`, and therefore `ApplicationNotifyQuitMethod` is also renamed to `ApplicationNotifyWillQuitMethod`.
> 
> ----------------
> 
> Commits:
>  - 0fe426ab: Rename notifyQuit and ApplicationNotifyQuitMethod to notifyWillQuit and ApplicationNotifyWillQuitMethod
> 
> Changes: https://git.openjdk.java.net/jfx/pull/58/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/58/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8235151
>   Stats: 9 lines in 3 files changed: 0 ins; 0 del; 9 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/58.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/58/head:pull/58

Looks like a trivial fix to me, that only impacts files specific to iOS.

----------------

Approved by jvos (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/58


More information about the openjfx-dev mailing list