[Rev 01] RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

[Jeanette Winzenburg]

On Tue, 10 Dec 2019 13:01:15 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextInputControlBehavior.java line 626:
>> 
>>> 625:     protected void fire(KeyEvent event) { } // TODO move to TextFieldBehavior
>>> 626:     protected void cancelEdit(KeyEvent event) { };
>>> 627: 
>> 
>> Will this code removal re-introduce JDK-8145515?
> 
> no don't think so: the fix for JDK-8145515 was to prevent the triggering of parent.fireEvent, so removing the method altogether should have no effect :) Could add a test to explicitly guard against this.
> 
> Please note that the old combo issue is back in the form of https://bugs.openjdk.java.net/browse/JDK-8229914 - before and after fixing this, combo does very bad things ;)

just to let you know: locally added test to explicitly guard against JDK-8145515 (and an ignored one for the regression JDK-8229914) - they are passing/failing the same before/after this fix. Will push later ...

-------------

PR: https://git.openjdk.java.net/jfx/pull/15