[Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

[Scott Palmer]

On Wed, 11 Dec 2019 01:22:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The unit tests that were already added to `TextTest.java` cover the new methods on Text, but not in every combination.  I'll add a couple more to ensure all combinations are covered. `TextFlow` has no existing unit tests that I could find!  Shall I add a new `TextFlowText.java` file for just these tests?
>> 
>> The apps/toys folder seems to use ant-based projects.  The existing ones don't build for me. If I made a new project there could I use the JavaFX Gradle plugin and configure it to get JavaFX from the build/sdk folder?
> 
> I think a new `TextFlowTest.java` would be a good place for those tests.
> 
> Our build is set up to use `ant` so if you want to wire it up to the build, you'll need that (it should be as simple as having `ANT_HOME` set to `apache-ant-1.10.5`). It would be fine to defer this if you can't get it working.

I just noticed while updating the CSR that, while I mentioned it on the mailing list, the fact that TextFlow's tabSize override that of any contained Text nodes is not documented.
Shall I add to the javadoc for tabSize  in TextFlow : "This value overrides the tabSize of contained Text nodes." ?

-------------

PR: https://git.openjdk.java.net/jfx/pull/32