[Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

[Scott Palmer]

On Thu, 12 Dec 2019 21:29:06 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1450:
> 
>> 1449:         private static final CssMetaData<Text,Number> TAB_SIZE =
>> 1450:                 new CssMetaData<Text,Number>("-fx-tab-size",
>> 1451:                 SizeConverter.getInstance(), TextLayout.DEFAULT_TAB_SIZE) {
> 
> I think that type parameters should have space separation after a comma: `Text, Number`, though I've seen without too.

Most of the instances where CssMetaData is used in the rest of the file don't have a space. The exceptions seem to be where there is a wildcard in the type parameter.  It could be left as-is simply to maintain consistency within the file.  Though I tend to agree that a space makes sense.

-------------

PR: https://git.openjdk.java.net/jfx/pull/32