[Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

Scott Palmer swpalmer at openjdk.java.net
Fri Dec 13 01:15:46 UTC 2019


On Thu, 12 Dec 2019 21:41:12 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1883:
> 
>> 1882:                     }
>> 1883:                     @Override protected void invalidated() {
>> 1884:                         TextLayout layout = getTextLayout();
> 
> I think that annotations tend to go on a line above what they annotate,

I'm following the pattern established elsewhere in the file for other property overrides. (underline, strikethrough, textAlignment, selectionEnd, etc.).  I would keep this for consistency and compactness, unless there are more votes against it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/32


More information about the openjfx-dev mailing list