[Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

Scott Palmer swpalmer at openjdk.java.net
Fri Dec 13 01:20:56 UTC 2019


On Thu, 12 Dec 2019 22:02:14 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line 494:
> 
>> 493:      * Values less than 1 are treated as 1. This value overrides the
>> 494:      * {@code tabSize} of contained {@link javafx.scene.text.Text Text} nodes.
>> 495:      *
> 
> `{@link Text}` is enough, but the FQN is also fine.
> 
> Does `Text`'s `tabSize` need a note that its value is overriden if the text is contained in a `TextFlow`?

TextFlow isn't mentioned in the JavaDoc for any of the other Text properties where the same rule applies.  Perhaps that should be remedied with a follow-up task?

-------------

PR: https://git.openjdk.java.net/jfx/pull/32


More information about the openjfx-dev mailing list