[Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

Hadzic Samir shadzic at openjdk.java.net
Mon Dec 16 09:41:39 UTC 2019


On Wed, 11 Dec 2019 00:32:32 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Thanks for the review. I do not have access to a computer right now, I'll
>> update next week on Monday.
>> 
>> Le lun. 9 déc. 2019 à 17:01, Kevin Rushforth <notifications at github.com> a
>> écrit :
>> 
>>> I would like both @aghaisas <https://github.com/aghaisas> and myself to
>>> review / approve this. I will sponsor it.
>>>
>>> In addition, the CSR needs to be approved before this can be integrated.
>>>
>>>>>> You are receiving this because you authored the thread.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/openjdk/jfx/pull/6?email_source=notifications&email_token=ACEL43KWFAJ32FX3NNSM7ETQX2W3LA5CNFSM4I5EYYAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKV3YQ#issuecomment-563437026>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/ACEL43PNZLRK37IM33ROVGDQX2W3LANCNFSM4I5EYYAA>
>>> .
>>>
> 
> I took the liberty of updating the CSR to add the missing comma, so I could mark it as Reviewed. You can Finalize the CSR when you are ready.

> 
> 
> I took the liberty of updating the CSR to add the missing comma, so I could mark it as Reviewed. You can Finalize the CSR when you are ready.

Thank you, I have committed new changes according to your review. I have also moved the CSR to "finalize".

Let me know if I need to do something else, sorry for the delay.

-------------

PR: https://git.openjdk.java.net/jfx/pull/6


More information about the openjfx-dev mailing list