[Rev 02] RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

Mon Dec 16 11:21:58 UTC 2019

On Mon, 16 Dec 2019 08:52:56 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> 

Zitat von "openjdk[bot]" <notifications at github.com>:

> @kleopatra This change can now be integrated. The commit message will be:
> ```

Ajit, Kevin,

hmm .. wondering if this message is a bot-error? Kevin stated that it  
needs two reviewers (approving, I assume?) but currently have one only  
- so question is: should I post the /integrate comment or not yet?

-- Jeanette

> 8207759: VK_ENTER not consumed by TextField when default Button exists
>
> Reviewed-by: aghaisas
> ```
> - If you would like to add a summary, use the `/summary` command.
> - To list additional contributors, use the `/contributor` command.
>
> Since the source branch of this PR was last updated there have been  
> 53 commits pushed to the `master` branch:
>  * fc539b57fbbebaab3c99c509d6e5f0e3b88858fa: 8223296:  
> NullPointerException in GlassScene.java at line 325
>  * 71ca899fbfc74d825c29b20a778d6d9eb243f90f: 8220722:  
> ProgressBarSkin: adds strong listener to control's width property
>  * 07af89a9e1a5e044d416e73dd14a84056fadf53c: 8221334: TableViewSkin:  
> must initialize flow's cellCount in constructor
>  * 4ddf55428d06dddadfc8cd14baabdc4d17318ee2: 8234916: [macos 10.15]  
> Garbled text running with native-image
>  * 46338d02754a5b5d475b065d492315fa307a0e3d: 8232524:  
> SynchronizedObservableMap cannot be be protected for copying/iterating
>  * a68347cbbf2191c981472c82c2b64d77bfbc613d: 8235150: IosApplication  
> does not pass the required object in _leaveNestedEventLoopImpl
>  * 1c27fbd218f1be2beac5cacbe93f202c11de439f: 8210955:  
> DOMTest::testEventListenerCascade fails
>  * 2d4096a8ffefb787bd71eb535231766a045e515f: 8235151: Nonexistent  
> notifyQuit method referred from iOS GlassHelper.m
>  * 98035cb2afef0c230d55095f0addeab73693d0ac: 8211308: Support HTTP/2  
> in WebView
>  * 6892fa1b3bbcfdb0e643a26441622916be987a38: 8232064: Switch FX  
> build to use JDK 13.0.1 as boot JDK
>  * 1d670f18d16d060dc40e83733cb3595c41df2a97: 8200224: Multiple press  
> event when JFXPanel gains focus
>  * 83eb0a7c9150566aae96db8ce9d1f78b714c9d1b: 8193445: JavaFX CSS is  
> applied redundantly leading to significant performance degradation
>  * 798afbcaeb73b90ba4bd511380786f7956e1b443: 8230610: Upgrade  
> GStreamer to version 1.16.1
>  * 126896db9928ae334332d38486fb61ad3a2e00a0: 8234704: Fix  
> attribution in libxslt.md
>  * 4d3c723e2f18efaca32a9df234063c7895b5540c: 8234593: Mark  
> LeakTest.testGarbageCollectability as unstable
>  * 5a398244af8f029d99d9cffc291667fc9c1ad9df: 8234056: Upgrade to  
> libxslt 1.1.34
>  * 8bea7b71454ada53881847c751add63e8fc99ea3: 8229472: Deprecate for  
> removal JavaBeanXxxPropertyBuilders constructors
>  * aad1720608856e910edaf05d0d53e87942642326: 8233420: Upgrade to gcc  
> 8.3 on Linux
>  * 42040c4cdb58eb0c6029a727df61b00248ee8e2b: 8232063: Upgrade gradle  
> to version 6.0
>  * aab07a4d01604355516de641b6141c91a30e0dc7: 8234239: [TEST_BUG]  
> Reenable few ignored web tests
>  * 95ad6017dc85b9504a4c20dd20f31094d9075f42: 8233421: Upgrade to  
> Visual Studio 2017 version 15.9.16
>  * 3e0557a815b6336d4e2eeaf5e833fe65f4298833: 8234303: [TEST_BUG]  
> Correct ignore tag in graphics unit tests
>  * e37cb37005b71edbf462eaa360c529a1e68c8656: 8234150: Address  
> ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and  
> TextInputControlTest
>  * 4f496d417915b450880cbe664cba9130ab76ca08: 8234194: [TEST_BUG]  
> Reenable few graphics unit tests
>  * 927fc8a0f88adcaeb069bf0a7218a9c3f875d707: 8234174: Change IDEA  
> VCS mapping to Git
>  * 3d0cb4966a240ce81d18acffd64939757b79bed5: 8234189: [TEST_BUG]  
> Remove ignored and invalid graphics unit tests
>  * dc0130944365b61ac4a4333df29d684e9566d3cf: 8234110:  
> SwingFXUtilsTest is unsuitable for unit test framework
>  * 5b96ee42ac786ec23b99564715679d352c1637be: 8231188: Update SQLite  
> to version 3.30.1
>  * d46dcae7a571724f10d58e424842d703ea1cb0e3: 8233338: FX javadoc  
> headings are out of sequence
>  * 94bcf3fcfce83bae8d2014f15e993ba2edf24e0f: 8231692: Test  
> Infrastructure: enhance KeyEventFirer to inject keyEvents into scene
>  * 286d1b5427a2b9724cb400335741ed99295c5141: 8230492: font-family  
> not set in HTMLEditor if font name has a number in it
>  * f74f3afba53404e5169d97ef0d78c3ef2eeb42ef: 8233040:  
> ComboBoxPopupControl: remove eventFilter for F4
>  * a1cc4ab03698e9e9add95ecad191c9d89c6f35dd: 8232210: Update Mesa  
> 3-D Headers to version 19.2.1
>  * dca8df4e5d9071622dbaf83be48ae71b0927e6ae: 8232943: Gesture  
> support is not initialized on iOS
>  * 5a70b0c58cd723b535a6385fc8b431175ef44565: 8189092:  
> ArrayIndexOutOfBoundsException on Linux in getCachedGlyph
>  * ac71396c9b1eb390cf09fde928fe5fbd9c31e089: 8232929: Duplicate  
> symbols when building static libraries
>  * ab6ea3b936f319cdea997aabed63ffdc639a75e1: 8232158: [macOS]  
> Fallback to command line tools if xcode is missing
>  * 2ae171a2a0e6d1c24e6943f4f9a48987f6ed8ef4: 8232687: No static JNI  
> loader for libprism-sw
>  * a09a0fa595de95d4311495b6584804910d7fa5b9: 8232522: FX: Update  
> copyright year in docs, readme files to 2020
>  * 582d9993d5908be1ceef2376e0242208a886ed0f: Merge
>  * b6e53f4f349a9fd5678500c56d34133c4fee2ac6: 8218640: Update ICU4C  
> to version 64.2
>  * bada612a59bbf46c14b3712e2b599044ef3872f7: Merge
>  * 64aaeb840aa157e358eb41001c3705aa5c2fee30: 8226754: FX build fails  
> using gradle 5.6+ or 6
>  * a4bc22d25f79f3f9658f5c6fc0d90f2bf34aa4cf: Merge
>  * 2593dea30b3610fef713ff4a215b6ae9d699ca3f: Merge
>  * 9df20c561473cd62375d5908234f9a81b39889a6: Merge
>  * a1aa38a479bf0449e39d14075980448058c8a0d3: Merge
>  * 0ff02bbcb5db2cc276c75ba0c18eb846fba8f0ad: Merge
>  * a433bf2752ace3d4dc0a9db0313d75768b64b253: Merge
>  * 561153dbc218d00dc0486b58db1a7a8cfeffb64a: Merge
>  * 75d439e969d9e4c7022f2eeb981787b371014456: Merge
>  * 758252f9c4e6c283bd9872ad2e2b7b95a2e0a94d: Merge
>  * 35e0caea17dd612cf69c1876a0649a8897ab88f0: 8227402: Improve XSLT processing
>
> Since there are no conflicts, your changes will automatically be  
> rebased on top of the above commits when integrating. If you prefer  
> to do this manually, please merge `master` into your branch first.
>
> As you do not have Committer status in this project, an existing  
> [Committer](https://openjdk.java.net/bylaws#committer) must agree to  
> [sponsor](https://openjdk.java.net/sponsor/) your change. Possible  
> candidates are the reviewers of this PR (@aghaisas) but any other  
> Committer may sponsor as well.
>
> - To flag this PR as ready for integration with the above commit  
> message, type `/integrate` in a new comment. (Afterwards, your  
> sponsor types `/sponsor` in a new comment to perform the integration).
> 
>
> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/openjdk/jfx/pull/15#issuecomment-565964995

-------------

PR: https://git.openjdk.java.net/jfx/pull/15