[Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

[Jeanette Winzenburg]

On Thu, 19 Dec 2019 15:44:37 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> for now, you could have a look at ProgressIndicatorTest (or ProgressSkinTest) attemptGC - might not be optimal (don't know enough about the dirty details of gc :) but gets the test failing/passing before/after fixing a memory leak
> 
> The point of having this GC-magic in a library is, that it's verified by the library that it's implementation is stable for all common JavaVersions. The attemptGC is basically bad practice. I think in the JavaFX-Codebase this kind of GC-Tests are invented about 10 times. No one knows which of these implementations are stable and their code is usually unreadable. I know it, I have done it multiple times.
> 
> Copying to Infrastructure would be fine for me. It removes some benefits, like easy upgrades, Travis-verified implementation etc. But it's probably the best short-term solution.

probably not  invented so often - just c&p'd from searches of occurances of System.gc ;-)

-------------

PR: https://git.openjdk.java.net/jfx/pull/71