[Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

[David Grieve]

On Thu, 19 Dec 2019 19:28:34 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Hi everyone,
>> 
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>> 
>> The fix itself is quite straight forward.
>> It basically just removed the listener which causes the leak.
>> 
>> The unit-test for the fix is a bit more complicated.
>> 
>> I added a library JMemoryBuddy https://github.com/Sandec/JMemoryBuddy (written by myself), which simplifies testing for memory leaks.
>> I think there are many places in the JavaFX-codebase that could highly benefit from this library.
>> It could also simplify many of the already existing unit tests.
>> It makes testing for memory-leaks readably and reliable. 
>> It would also be possible to just copy the code of the library into the JavaFX-codebase. 
>> It only contains a single class.
>> 
>> I also had to make a method public, to write the test. I'm open to ideas, how I could solve it differently.
> 
> The pull request has been updated with 1 additional commit.

modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/ProgressIndicatorSkinTest.java line 106:

> 105:             Node detIndicator = indicator.getChildrenUnmodifiable().get(0);
> 106:             System.out.println(detIndicator.getClass().getSimpleName());
> 107:             checker.assertCollectable(detIndicator);

remove

-------------

PR: https://git.openjdk.java.net/jfx/pull/71