[Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings
Thiago Milczarek Sayao
tsayao at openjdk.java.net
Thu Dec 19 20:24:37 UTC 2019
On Thu, 19 Dec 2019 14:29:39 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1062:
>
>> 1061: geometry.final_height.type = BOUNDSTYPE_CONTENT;
>> 1062: }
>> 1063:
>
> So now `geometry.final_width.value` and `geometry.final_height.value` will be set after the `Dialog `is displayed on screen.
> Does this mean that, the `Dialog` will be resized after it is displayed ? I did not observe any size change visually.
>
> An observation unrelated to this change: `Dialog` changes it's position after being displayed. It can not be observed always, but is very frequent. Should be easy to observe it on a slow machine.
> On the same machine, I did not observe any size change though.
No, it will be set on set_bounds(). This will just update de final value after show() / map.
-------------
PR: https://git.openjdk.java.net/jfx/pull/63
More information about the openjfx-dev
mailing list