[Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

Thiago Milczarek Sayao tsayao at openjdk.java.net
Thu Dec 19 20:36:15 UTC 2019


On Tue, 17 Dec 2019 21:37:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java line 63:
> 
>> 62:     @Test(timeout = 15000)
>> 63:     public void dialogWithOwnerSizingTest() throws Exception {
>> 64:         Thread.sleep(500);
> 
> This test fails on Windows 10 with 125% screen scaling. The size of the two dialogs are not exactly the same: 181.6 vs 180.0. I recommend either excluding the test or else adding a 2 pixel tolerance if the DPI scaling factor is non-integral.

Added 2 pixels tolerance.

-------------

PR: https://git.openjdk.java.net/jfx/pull/63


More information about the openjfx-dev mailing list