RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

[Ambarish Rapte]

On Fri, 20 Dec 2019 09:50:35 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8235627
> 
> modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m line 97:
> 
>> 96:         if (pix == NULL)
>> 97:         {
>> 98:             const CGLPixelFormatAttribute attributes2[] =
> 
> The change looks good.
> I would suggest to print a message inside the if block, mentioning that the first attempt to create a pixel format object has failed and second attempt is being made with minimal attributes.
> Also please use `CGLErrorString(err)`  when printing the error message.

Additionally the if condition at line 105 can be changed to match with the change. as,
`if (pix == NULL || err != kCGLNoError)`

-------------

PR: https://git.openjdk.java.net/jfx/pull/65