RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors
Nir Lisker
nlisker at openjdk.org
Wed Nov 6 11:50:27 UTC 2019
On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>
>> On Wed, 6 Nov 2019 05:04:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>>
>>> On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8229472
>>>>
>>>> CSR will be created after the changes are approved.
>>>>
>>>> ----------------
>>>>
>>>> Commits:
>>>> - 6d29e034: Initial push of 8229472
>>>>
>>>> Changes: https://git.openjdk.java.net/jfx/pull/30/files
>>>> Webrev: https://webrevs.openjdk.java.net/jfx/30/webrev.00
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8229472
>>>> Stats: 14 lines in 7 files changed: 7 ins; 0 del; 7 mod
>>>> Patch: https://git.openjdk.java.net/jfx/pull/30.diff
>>>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/30/head:pull/30
>>>
>>> modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanBooleanPropertyBuilder.java line 68:
>>>
>>>> 67: @Deprecated(since = "14", forRemoval = true)
>>>> 68: public JavaBeanBooleanPropertyBuilder() {}
>>>> 69:
>>>
>>> Minor: I checked other places in JavaFX and JDK, and they consistently omit the spaces surrounding the `=`.
>>
>> I changed the bug summary to include `for removal` in the title. Can you change the PR title to match?
>
> Thanks for the notification, looks like GitHub returned 500 for a few minutes. This seem to happen from time to time, so nice to know that the retry logic works. :)
For both `since` and `forRemoval`?
PR: https://git.openjdk.java.net/jfx/pull/30
More information about the openjfx-dev
mailing list