[Rev 02] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

Ajit Ghaisas aghaisas at openjdk.org
Fri Nov 8 07:14:48 UTC 2019


On Thu, 7 Nov 2019 11:51:02 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> The pull request has been updated with additional changes.
> 
> ----------------
> 
> Added commits:
>  - 92cd944e: changed as requested in review
> 
> Changes:
>   - all: https://git.openjdk.java.net/jfx/pull/20/files
>   - new: https://git.openjdk.java.net/jfx/pull/20/files/0366a0a5..92cd944e
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jfx/20/webrev.02
>  - incr: https://webrevs.openjdk.java.net/jfx/20/webrev.01-02
> 
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8231692
>   Stats: 83 lines in 2 files changed: 10 ins; 65 del; 8 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/20.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/20/head:pull/20

modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/KeyEventFirerTest.java line 115:

> 114:         correctFirer.doKeyPress(A);
> 115:         assertNotEquals(falseTextFieldNotification, textFieldEvents.size());
> 116:         assertNotEquals(falseButtonNotification, buttonEvents.size());

assertNotEquals does not compile for me.

PR: https://git.openjdk.java.net/jfx/pull/20


More information about the openjfx-dev mailing list