RFR: 8234174: Change IDEA VCS mapping to Git

[Alexander Scherbatiy]

On Thu, 14 Nov 2019 15:18:15 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> On Thu, 14 Nov 2019 15:06:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> 
>> On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:
>> 
>>> Allow IDEA to correctly detect Git version control system when opening JFX project.
>>> 
>>> ----------------
>>> 
>>> Commits:
>>>  - f0f1866a: 8234174: Change IDEA VCS mapping to Git
>>> 
>>> Changes: https://git.openjdk.java.net/jfx/pull/37/files
>>>  Webrev: https://webrevs.openjdk.java.net/jfx/37/webrev.00
>>>   Issue: https://bugs.openjdk.java.net/browse/JDK-8234174
>>>   Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
>>>   Patch: https://git.openjdk.java.net/jfx/pull/37.diff
>>>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/37/head:pull/37
>> 
>> Adding to what @tsayao said, there is a JBS issue, [JDK-8223373](https://bugs.openjdk.java.net/browse/JDK-8223373), to remove the `.idea` files from the repo.
>> 
>> I think this change is fine in the short term even if we end up removing the .idea files in the near future.
>> 
>> .idea/vcs.xml line 8:
>> 
>> 
>> Minor: can you restore the newline that was removed? It isn't related to the change, and in general, text files should end with a newline (although that's a suggestion, not a rule).
> 
> I use IDEA 2019.2.4.
> I tried to remove the .idea directory from jfx project and and open jfx project by IDEA using File -> New -> Project From Existing Sources...  and point to jfx/build.gradle file.
> It started to analyze the project and just silently stops importing the project without any message in the ~/.IdeaIC2019.2/system/log/idea.log file.

Some .idea files are already in [.gitignore](https://github.com/openjdk/jfx/blob/master/.gitignore)
# Ignore IntelliJ files
.idea/tasks.xml
.idea/workspace.xml
.idea/inspectionProfiles/**
.idea/copyright/profiles_settings.xml
.idea/codeStyles/**
.idea/checkstyle-idea.xml

PR: https://git.openjdk.java.net/jfx/pull/37