[Approved] RFR: 8234174: Change IDEA VCS mapping to Git
Kevin Rushforth
kcr at openjdk.org
Thu Nov 14 16:37:10 UTC 2019
On Thu, 14 Nov 2019 15:30:09 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:
> The pull request has been updated with additional changes.
>
> ----------------
>
> Added commits:
> - c55e4d81: Restore new line in the end of .idea/vcs.xml file
>
> Changes:
> - all: https://git.openjdk.java.net/jfx/pull/37/files
> - new: https://git.openjdk.java.net/jfx/pull/37/files/f0f1866a..c55e4d81
>
> Webrevs:
> - full: https://webrevs.openjdk.java.net/jfx/37/webrev.01
> - incr: https://webrevs.openjdk.java.net/jfx/37/webrev.00-01
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8234174
> Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
> Patch: https://git.openjdk.java.net/jfx/pull/37.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/37/head:pull/37
Looks good. Since this is a trivial, and obviously correct, change to an IDE file, it only needs a single reviewer. You may integrate it when ready; I'll sponsor it.
----------------
Approved by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/37
More information about the openjfx-dev
mailing list