[Approved] RFR: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests
Kevin Rushforth
kcr at openjdk.org
Thu Nov 14 18:15:34 UTC 2019
On Thu, 14 Nov 2019 17:53:29 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
> Following unit tests are to be removed:
> 1. test.com.sun.javafx.iio.ImageLoaderScalingTest.testAllTheScalesJPG:
> Color of a pixel in original and scaled jpg image can not be guarantted to be same.
>
> 2. test.javafx.scene.layout.BackgroundSizeTest.negativeWidthThrowsException3
> test.javafx.scene.layout.BackgroundSizeTest.negativeHeightThrowsException3:
> Double.MIN_VALUE is not < 0 and there are tests included for negative value.
>
> 3.test.javafx.scene.input.PasteboardTest: Pasteboard is removed.
>
> 4. test.javafx.scene.input.TouchEventTest.shouldThrowREOnLostIndirectRelease:
> Indirect gesture touch events are not supported yet. There will be lot of more tests needed once we decide to support the Indirect gesture events. This test can be reintroduced after that.
>
> ----------------
>
> Commits:
> - a8ecc824: Remove ignored and invalid graphics unit tests
>
> Changes: https://git.openjdk.java.net/jfx/pull/38/files
> Webrev: https://webrevs.openjdk.java.net/jfx/38/webrev.00
> Issue: https://bugs.openjdk.java.net/browse/JDK-8234189
> Stats: 167 lines in 4 files changed: 0 ins; 164 del; 3 mod
> Patch: https://git.openjdk.java.net/jfx/pull/38.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/38/head:pull/38
Looks good. Since this is a simple test fix, one reviewer is sufficient.
----------------
Approved by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/38
More information about the openjfx-dev
mailing list