[Rev 01] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors
Ambarish Rapte
arapte at openjdk.org
Mon Nov 18 17:48:43 UTC 2019
On Wed, 6 Nov 2019 14:28:20 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
> The pull request has been updated with additional changes.
>
> ----------------
>
> Added commits:
> - a1cdb37b: Removed whitespaces in @Deprecated comments
>
> Changes:
> - all: https://git.openjdk.java.net/jfx/pull/30/files
> - new: https://git.openjdk.java.net/jfx/pull/30/files/6d29e034..a1cdb37b
>
> Webrevs:
> - full: https://webrevs.openjdk.java.net/jfx/30/webrev.01
> - incr: https://webrevs.openjdk.java.net/jfx/30/webrev.00-01
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8229472
> Stats: 7 lines in 7 files changed: 0 ins; 0 del; 7 mod
> Patch: https://git.openjdk.java.net/jfx/pull/30.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/30/head:pull/30
Please add @deprecated javadoc tag in the description for all constructors.
modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanBooleanPropertyBuilder.java line 66:
> 65: * This constructor was exposed erroneously and will be removed in the next version. Use {@link #create()} instead.
> 66: */
> 67: @Deprecated(since="14", forRemoval=true)
I think @deprecated javadoc tag should be added to all the descriptions.
It will change the way Description gets shown in both, Constructor Summary and Constructor Detail section.
----------------
Changes requested by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/30
More information about the openjfx-dev
mailing list