[Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Nov 21 15:38:51 UTC 2019


On Wed, 13 Nov 2019 11:26:35 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:

> The pull request has been updated with additional changes.
> 
> ----------------
> 
> Added commits:
>  - e1a9d2d0: Add more unit tests upon review
> 
> Changes:
>   - all: https://git.openjdk.java.net/jfx/pull/6/files
>   - new: https://git.openjdk.java.net/jfx/pull/6/files/2b088993..e1a9d2d0
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jfx/6/webrev.05
>  - incr: https://webrevs.openjdk.java.net/jfx/6/webrev.04-05
> 
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
>   Stats: 185 lines in 2 files changed: 117 ins; 48 del; 20 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/6.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6

looks okay to me :)

----------------

Approved by fastegal (Author).

PR: https://git.openjdk.java.net/jfx/pull/6


More information about the openjfx-dev mailing list