[Approved] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

Kevin Rushforth kcr at openjdk.java.net
Tue Nov 26 18:52:30 UTC 2019


On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> The pull request has been updated with additional changes.
> 
> ----------------
> 
> Added commits:
>  - 2054da4c: Address review comments on test
>  - 4dade6e5: Simpler fix + System test corrections
>  - bd4a306a: Revert commit1 and commit 2
> 
> Changes:
>   - all: https://git.openjdk.java.net/jfx/pull/34/files
>   - new: https://git.openjdk.java.net/jfx/pull/34/files/12ea8220..2054da4c
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jfx/34/webrev.01
>  - incr: https://webrevs.openjdk.java.net/jfx/34/webrev.00-01
> 
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8193445
>   Stats: 253 lines in 6 files changed: 132 ins; 104 del; 17 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/34.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/34/head:pull/34

Looks good.

----------------

Approved by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/34


More information about the openjfx-dev mailing list