genVSproperties.bat: why unset variables?

[Michael Ennen]

Ilya,

I also had trouble with genVSproperties.bat (as did other historically)

This led me to create a Powershell build script which was merged to
upstream:

https://github.com/openjdk/jfx/blob/master/tools/scripts/build.ps1

I strongly recommend using it when building locally on Windows.


On Mon, Oct 7, 2019 at 3:16 PM Ilya Kazakevich <
ilya.kazakevich at jetbrains.com> wrote:

> Hello.
>
> I was trying to build jfx for Windows using cygwin.
> I launched cygwin from VS prompt with all variables set, but when build
> failed,
> I realized that ``windows_tools.properties`` is almost empty.
>
> It happened because ``genVSproperties.bat`` failed to locate my toolchain
> and
> it explicitly removed my variables!
>
> REM Clean out the current settings
> set INCLUDE=
> set LIB=
> set LIBPATH=
>
> Why so? Is not it better to remove this lines and always launch build via
> VS prompt?
> After all, this is what it was created for)
>
> Ilya.
>


-- 
Michael Ennen