[Approved] RFR: 8231870: Updated armv6hf crosslibs script with new domains
Johan Vos
jvos at openjdk.org
Wed Oct 9 07:41:24 UTC 2019
On Mon, 7 Oct 2019 13:35:51 GMT, Dell Green <12861109+dellgreen at users.noreply.github.com> wrote:
> buildSrc/crosslibs-armv6hf.sh pulls down debian and raspbian packages to be able to cross compile javafx for arm hard float. Up to now the upstream distribution versions have been debian and raspbian wheezy, but these are now end of life and have been archived to servers that have different domain names.
>
> Tried to change to use jessie but this generates a whole load of __THROWNL errors, so for now have updated the domain names to point to new servers so that wheezy packages can still be retrieved and cross compilation succeeds.
>
> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8231870
>
> ----------------
>
> Commits:
> - bb4bcc9e: 8231870: Updated armv6hf crosslibs script with new resource domain names for wheezy
>
> Changes: https://git.openjdk.java.net/jfx/pull/8/files
> Webrev: https://webrevs.openjdk.java.net/jfx/8/webrev.00
> Issue: https://bugs.openjdk.java.net/browse/JDK-8231870
> Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
> Patch: https://git.openjdk.java.net/jfx/pull/8.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/8/head:pull/8
I am ok with the PR as is. The decision on how to install build tools (e.g. via apt-get, via a zip download, over http, over https) is not part of the code repository, and can be specific to the distributor.
This PR fixes something that was broken (unavailable host) so +1 for this.
----------------
Approved by jvos (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/8
More information about the openjfx-dev
mailing list