[Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation
Kevin Rushforth
kcr at openjdk.org
Wed Oct 9 16:18:49 UTC 2019
On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:
> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:
>
>> The pull request has been updated with additional changes.
>>
>> ----------------
>>
>> Added commits:
>> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for clarification on TableColumnHeader
>>
>> Changes:
>> - all: https://git.openjdk.java.net/jfx/pull/6/files
>> - new: https://git.openjdk.java.net/jfx/pull/6/files/969ebb51..e846e51c
>>
>> Webrevs:
>> - full: https://webrevs.openjdk.java.net/jfx/6/webrev.01
>> - incr: https://webrevs.openjdk.java.net/jfx/6/webrev.00-01
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
>> Stats: 27 lines in 3 files changed: 13 ins; 1 del; 13 mod
>> Patch: https://git.openjdk.java.net/jfx/pull/6.diff
>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 608:
>
>> 607: protected void resizeColumnToFitContent(int maxRows) {
>> 608: TableColumnBase<?, ?> tc = getTableColumn();
>> 609: if (!tc.isResizable()) return;
>
> I have put the `since 14`, because if merged, it will be available in OpenJFX 14 right? (It was 13 before)
Correct.
PR: https://git.openjdk.java.net/jfx/pull/6
More information about the openjfx-dev
mailing list