RFR: WIP: 8230231: font-family not updated in HTMLEditor

Thu Oct 10 09:12:57 UTC 2019

On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:
> 
>> On Wed, 9 Oct 2019 16:09:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> 
>>> On Wed, 9 Oct 2019 16:09:06 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:
>>> 
>>>> Fix for https://github.com/javafxports/openjdk-jfx/issues/573
>>>> 
>>>> Issue on JDK bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231
>>>> 
>>>> I tried to add a test but I do not succeed at even running the existing Web tests.. I will need some help on that side..
>>>> 
>>>> ----------------
>>>> 
>>>> Commits:
>>>>  - e9df9db5: Adding double-quote for HTMLEditorSkin font-family
>>>> 
>>>> Changes: https://git.openjdk.java.net/jfx/pull/12/files
>>>>  Webrev: https://webrevs.openjdk.java.net/jfx/12/webrev.00
>>>>   Issue: https://bugs.openjdk.java.net/browse/JDK-8230231
>>>>   Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
>>>>   Patch: https://git.openjdk.java.net/jfx/pull/12.diff
>>>>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/12/head:pull/12
>>> 
>>> @Maxoudela please edit the title as follows:
>>> 
>>> 1. Remove the space before the `:` (that extra space is why jcheck failed)
>>> 2. Change the text of the title to match the JBS bug summary exactly. You can edit the JBS bug summary if you feel it needs to be changed, but in this case, the JBS bug has a title that is more in line with our usual practice of having the bug title be descriptive of what the problem is and not what the solution happens to be.
>>> 
>>> As for unit tests, you will very likely need to add this as a system test under `tests/system/src/main/test`. See [tests/system/src/test/java/test/javafx/scene/web/HTMLEditorTest.java](https://github.com/openjdk/jfx/blob/master/tests/system/src/test/java/test/javafx/scene/web/HTMLEditorTest.java). Presuming that you can add your test to that existing class, you would run it as follows:
>>> 
>>> gradle -PFULL_TEST=true :systemTests:test --tests HTMLEditorTest
>> 
>> Thanks @kevinrushforth . I'm sorry for posting the Pull request like that, I will thoroughly read the contributing guidelines and updates my PR accordingly.
>> 
>> I'll try to add a test asap, thanks for the pointer.
> 
>> I'm sorry for posting the Pull request like that
> 
> No problem. I mainly wanted to make sure that you knew why the RFR wasn't sent. As for the note about the title matching, the contributing guidelines don't mention that and I now realize that they should -- I'll add that along with some other improvements I'll be making.
> 
>> I'll try to add a test asap, thanks for the pointer.
> 
> Great, thanks.

Hum I do not succeed in running the existing test either. Here is my log. Apparently, the tests are failing because the WebView is null and not initialized. Do you have any clue of what I've been doing wrong? 

Should I try to update my gradle version and JDK version maybe?
gradle -PFULL_TEST=true :systemTests:test --tests HTMLEditorTest
Starting a Gradle Daemon (subsequent builds will be faster)

> Configure project :
MACOSX_MIN_VERSION = 10.9
MACOSX_SDK_PATH = /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk
*****************************************************************
Unsupported gradle version 4.8 in use.
Only version 5.3 is supported. Use this version at your own risk
*****************************************************************
gradle.gradleVersion: 4.8
OS_NAME: mac os x
OS_ARCH: x86_64
JAVA_HOME: /Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home
JDK_HOME: /Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home
java.runtime.version: 11.0.1+13
java version: 11.0.1
java build number: 13
jdk.runtime.version: 11.0.1+13
jdk version: 11.0.1
jdk build number: 13
minimum jdk version: 11
minimum jdk build number: 28
XCODE version: Xcode10.1-MacOSX10.14+1.0
cmake version: 3.13.3
ninja version: 1.8.2
ant version: 1.10.5
HAS_JAVAFX_MODULES: false
STUB_RUNTIME: /Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home
CONF: Debug
NUM_COMPILE_THREADS: 1
COMPILE_TARGETS: mac
COMPILE_FLAGS_FILES: buildSrc/mac.gradle
HUDSON_JOB_NAME: not_hudson
HUDSON_BUILD_NUMBER: 0000
PROMOTED_BUILD_NUMBER: 0
PRODUCT_NAME: OpenJFX
RELEASE_VERSION: 14
RELEASE_SUFFIX: -internal
RELEASE_VERSION_SHORT: 14-internal
RELEASE_VERSION_LONG: 14-internal+0-2019-10-10-110056
RELEASE_VERSION_PADDED: 14.0.0.0
MAVEN_VERSION: 14-internal+0-2019-10-10-110056
UPDATE_STUB_CACHE: false
Building Webkit configuration /Release/ into /Users/shadzic/jfx/modules/javafx.web/build/mac
module: project ':apps' (buildModule=NO)
module: project ':base' (buildModule=YES)
module: project ':controls' (buildModule=YES)
module: project ':fxml' (buildModule=YES)
module: project ':graphics' (buildModule=YES)
module: project ':media' (buildModule=YES)
module: project ':swing' (buildModule=YES)
module: project ':swt' (buildModule=NO)
module: project ':systemTests' (buildModule=NO)
module: project ':web' (buildModule=YES)

> Task :web:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :web:compileShimsJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :web:compileTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :systemTests:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :systemTests:test

test.javafx.scene.web.HTMLEditorTest > checkStyleWithCSS FAILED
    java.lang.NullPointerException
        at test.javafx.scene.web.HTMLEditorTest.lambda$checkStyleWithCSS$7(HTMLEditorTest.java:192)

test.javafx.scene.web.HTMLEditorTest > checkStyleProperty FAILED
    java.lang.NullPointerException
        at test.javafx.scene.web.HTMLEditorTest.lambda$checkStyleProperty$11(HTMLEditorTest.java:266)

3 tests completed, 2 failed, 1 skipped

> Task :systemTests:test FAILED

PR: https://git.openjdk.java.net/jfx/pull/12