Skara transition: openjdk/jfx GitHub repo is ready to accept pull requests

Nir Lisker nlisker at gmail.com
Thu Oct 10 12:40:29 UTC 2019


Hi Kevin,

A few questions and comments:

1. I'm getting double notifications from threads I'm subscribed to - one
from GitHub and one from the bot, including notifications on my own
comments. The Skara bot doesn't need to notify me on threads I'm subscribed
to.
2. Are the hg files like hgignore and hgtags still needed in the GitHub
Skara repo?
3. Is there a plan for the bot to be CSR-aware? For example, add to the
checklist the CSR status when applicable?
4. I updated the build instructions page on the Wiki to remove the
Mercurial requirements and update the Git tools and repo address. The page
could use a cleanup for the sections "Before you start" and anything below
and including "Testing with JDK 9 or JDK 10".
5. Not directly Skara related, but I could not find where the rule that
OpenJFX is compatible with JDK N and N-1 is stated. I see that the section
"Contributing to the OpenJFX codebase" in Contributing.md lists JDK 11 as
the minimum, but doesn't it apply to users of the library too?

- Nir


On Wed, Oct 2, 2019 at 4:52 PM Kevin Rushforth <kevin.rushforth at oracle.com>
wrote:

> The openjdk/jfx repo is now open and accepting pull requests. Refer to
> the links in the included message below for more information.
>
> One thing to note: there is not yet a CI job hooked up to the repo.
> Contributors, Committers, and Reviewers need to take this into account
> when testing.
>
> Please report any problems that you run into by replying to this thread.
>
> Thanks.
>
> -- Kevin
>
>
> On 10/1/2019 9:13 AM, Kevin Rushforth wrote:
> > As announced in this message [1], we are transitioning the official
> > openjfx mainline repo from Mercurial (hosted on hg.openjdk.java.net)
> > to GIT (hosted on github.com). Effective immediately, the HG
> > openjfx/jfx-dev/rt [2] repo is frozen. No more pushes to this repo
> > will be accepted. Similarly, no more pull requests will be accepted
> > against the GitHub javafxports/openjdk-jfx [3] sandbox repo.
> >
> > I have one final push to HG which will add the .jcheck/conf file
> > needed by Skara [4]. I will do some sanity testing, and then the HG
> > repo will be made read-only.
> >
> > I will send an announcement tomorrow morning when the new GitHub
> > openjdk/jfx [5] repo is open for accepting pull requests. In the mean
> > time, you can fork and clone the new repo as indicated here [6] to
> > prepare for this.
> >
> > Let me know if you have any questions.
> >
> > -- Kevin
> >
> > [1]
> >
> https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023551.html
> > [2] http://hg.openjdk.java.net/openjfx/jfx-dev/rt
> > [3] https://github.com/javafxports/openjdk-jfx
> > [4] https://bugs.openjdk.java.net/browse/JDK-8231310
> > [5] https://github.com/openjdk/jfx
> > [6]
> >
> https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html
>
>


More information about the openjfx-dev mailing list