RFR: 8207957: TableSkinUtils should not contain actual code implementation

[Hadzic Samir]

On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:
> 
>> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
>> 
>>> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir <shadzic at openjdk.org> wrote:
>>> 
>>>> Allright, this is a fix for JDK-8207957
>>>> 
>>>> ----------------
>>>> 
>>>> Commits:
>>>>  - 969ebb51: Fixing TableColumnHeaderTest
>>>>  - 9d379619: Removing Tablecolumnbasehelper
>>>>  - 4fe020fc: Fix javadoc for TableColumnHeader
>>>>  - c422c80f: Minor modification and uni test added.
>>>>  - b2bdfb5b: Change resizeColumn to protected without static in order to be able to override
>>>>  - 3b9b7903: Second option for resizeColumnToFitContent in TableColumnHeader
>>>>  - d91c56e5: First attempt to extract resizeColumnToFitContent
>>>> 
>>>> Changes: https://git.openjdk.java.net/jfx/pull/6/files
>>>>  Webrev: https://webrevs.openjdk.java.net/jfx/6/webrev.00
>>>>   Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
>>>>   Stats: 523 lines in 4 files changed: 330 ins; 187 del; 6 mod
>>>>   Patch: https://git.openjdk.java.net/jfx/pull/6.diff
>>>>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6
>>> 
>>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 600:
>>> 
>>>> 599:      * expensive if the number of rows is large. Subclass can either call this method or override it (no need to call
>>>> 600:      * {@code super()}) to provide their custom algorithm.
>>>> 601:      *
>>> 
>>> see https://github.com/javafxports/openjdk-jfx/pull/289#discussion_r245482213 - I think I made a suggestion (that probably needs some native speaker's fine tuning :)
>> 
>> Allright @kleopatra , I have indeed removed the TableColumn argument. It is clearer now that we are resizing the TableColumn of the header.
>> 
>> I have updated the description a bit but really I'm really not good at method description so I'm open to all suggestions..
> 
> A Draft CSR was filed here: [JDK-8215554](https://bugs.openjdk.java.net/browse/JDK-8215554). It will need to be updated once the API review is complete.

Do you think this looks good now @kleopatra @nlisker ?

PR: https://git.openjdk.java.net/jfx/pull/6