[Rev 01] RFR: 8242489: ChoiceBox: initially toggle not sync'ed to selection

[Jeanette Winzenburg]

On Tue, 14 Apr 2020 14:09:13 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ChoiceBox: added FIXME with reference to issue
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ChoiceBox.java line 185:
> 
>> 184:                 sm.selectedItemProperty().addListener(selectedItemListener);
>> 185:                 // unfixed part of JDK-8090015 - why exclude null?
>> 186:                 if (sm.getSelectedItem() != null && ! valueProperty().isBound()) {
> 
> Add a TODO: or FIXME: if you intend to work on it. Also, it will be better to create a JBS issue.
> 
> If not - please remove the comment.

Actually forgot that comment, already filed and took the issue JDK-8242001
thanks, eagle eye :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/177