RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

Craig Cavanaugh github.com+636962+ccavanaugh at openjdk.java.net
Fri Apr 17 09:26:33 UTC 2020


On Tue, 14 Apr 2020 09:04:40 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> was: https://github.com/openjdk/jfx/pull/136
>
> I am taking a look at your changes now.
> @ccavanaugh can you make jcheck pass while I review. Please see the details of the failing jcheck.

Thank you.  I've updated the pull request comments with what I thought was
the necessary changes, but jcheck is still failing with

"the commits in this PR have inconsistent user names and/or email
addresses. Please amend the commits."

I'm not sure what to do with this error.

Thanks,
Craig

On Tue, Apr 14, 2020 at 5:04 AM Ajit Ghaisas <notifications at github.com>
wrote:

> I am taking a look at your changes now.
> @ccavanaugh <https://github.com/ccavanaugh> can you make jcheck pass
> while I review. Please see the details of the failing jcheck.
>
>> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jfx/pull/166#issuecomment-613318893>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAE3QISJFVRRHVFI3XXI6U3RMQRLRANCNFSM4MES2KIA>
> .
>

-------------

PR: https://git.openjdk.java.net/jfx/pull/166


More information about the openjfx-dev mailing list