[Rev 01] RFR: 8175358: Memory leak when moving MenuButton into another Scene

Ajit Ghaisas aghaisas at openjdk.java.net
Mon Apr 27 12:35:11 UTC 2020


> Issue : https://bugs.openjdk.java.net/browse/JDK-8175358
> 
> Root cause : When a MenuItem is removed from a Scene, if any accelerator has been set on MenuItem, it does not get
> removed from Scene's list of accelerators.
> Fix : If Scene changes for a Menu, remove the registered accelerators from Scene.
> 
> Testing : Added a unit test that fails before the fix and passes with it.

Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:

  spelling_correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/199/files
  - new: https://git.openjdk.java.net/jfx/pull/199/files/e18b0cc9..8e3cfd25

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/199/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/199/webrev.00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/199.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/199/head:pull/199

PR: https://git.openjdk.java.net/jfx/pull/199


More information about the openjfx-dev mailing list