[Rev 01] RFR: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

John Neffenger github.com+1413266+jgneff at openjdk.java.net
Mon Apr 27 15:51:47 UTC 2020


On Mon, 27 Apr 2020 11:09:51 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

>> See the detailed issue description on: http://mail.openjdk.java.net/pipermail/openjfx-dev/2020-April/025975.html
>> 
>> The fix 8236448 https://github.com/openjdk/jfx/pull/75 changes
>> [MonocleApplication.staticScreen_getScreens()](https://github.com/openjdk/jfx/pull/75/files#diff-b66ff7fe72c6c5cd26003572ca901bfdL228)
>> method code from
>>> ns.getDPI(), ns.getDPI(), ns.getScale(), ns.getScale(), ns.getScale(), ns.getScale()
>> 
>>  to
>>  > ns.getWidth(), ns.getHeight(), 1.f, 1.f, ns.getScale(), ns.getScale()"
>> 
>> so the font size is not properly calculated based on the given DPI value.
>> 
>> I left the platformScaleX and platformScaleY as 1.f because I do not know how it affects Android/Dalvik platform. On
>> Raspberry Pi where I run JavaFX code with Monocle the DispmanScreen is used which have fixed scale 1.0 value so the app
>> works in the same way.
>
> Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Search javafx.platform.properties in jfx-runtime/lib directory

Thanks, Alexander! I just tested your pull request again, and JavaFX is now picking up the properties file along with
the correct native screen DPI on my Monocle ARM platform.

-------------

Marked as reviewed by jgneff at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jfx/pull/193


More information about the openjfx-dev mailing list