[Rev 04] RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

[Florian Kirmaier]

On Mon, 27 Apr 2020 15:09:17 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8241840
>>   The tests are now reused for native and monocle tests.
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Window.java line 1325:
> 
>> 1324:             this.isFocused = focused;
>> 1325:             if (this.isFocused && this.isVisible) {
>> 1326:                 setFocusedWindow(this);
> 
> On my Window10 machine, with this change, `Window.focusedWindow` remains `null` even after the first window (I have not
> verified with multiple windows though) is shown onto the screen and is focused. And It continues to remain `null` until
> some mouse or key action is performed on the window. I am not sure if this causes any side effects. It looks like the
> `Window.focusedWindow` is mostly(only) used for Monocle. Can you please confirm the behavior that
> `Window.focusedWindow` remain `null` and check for any side effects.

As mentioned - I don't have a good setup to test this code on Windows.

But I've checked where focusedWindow/getFocusedWindow is used, and I can verify your assumption. I've searched through
the whole project and the variable is only used in the MonocleCode.

The fact that focusedWindow get's sometimes set is probably the cause of the irregular happening memoryleak on Window.

-------------

PR: https://git.openjdk.java.net/jfx/pull/153