RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list

Ambarish Rapte arapte at openjdk.java.net
Thu Apr 30 12:57:16 UTC 2020


On Thu, 30 Apr 2020 11:22:33 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Would you consider moving both into a unit test? Have one locally, could send it to you ..

A ready test �� , That's very nice of you. Yes, We can move all the four tests to unit test. But I would prefer to do
it as another TEST_BUG.  Does that sound good ?

> Btw, the pattern in the listener (of collecting up additions/removals) is a bit smelly

I did try to change whole implementation, but it looked like a big change for the issue we have. The fix is very
minimal and local.


> it should not name it "permutation"

Shall think of a new name when we move the tests..

-------------

PR: https://git.openjdk.java.net/jfx/pull/201


More information about the openjfx-dev mailing list