RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v2]

Florian Kirmaier fkirmaier at openjdk.java.net
Thu Aug 13 17:12:01 UTC 2020


On Thu, 13 Aug 2020 16:35:51 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8251241
>>   Added missing spaces to match the coding style.
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow+Java.m line 100:
> 
>> 99:             type = com_sun_glass_events_WindowEvent_MINIMIZE;
>> 100:         } else if([self->nsWindow isZoomed]) {
>> 101:             type = com_sun_glass_events_WindowEvent_MAXIMIZE;
> 
> Minor: can you add a space between `if` and `(` to match our coding style?

Done!

-------------

PR: https://git.openjdk.java.net/jfx/pull/280


More information about the openjfx-dev mailing list