RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle. [v5]

Florian Kirmaier fkirmaier at openjdk.java.net
Thu Aug 13 19:27:28 UTC 2020


On Fri, 7 Aug 2020 21:38:27 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8241840
>>   The tests are now reused for native and monocle tests.
>
> tests/system/src/test/java/test/javafx/stage/FocusedWindowTestBase.java line 60:
> 
>> 59:     static WeakReference<Stage> closedFocusedStageWeak = null;
>> 60:     static Stage closedFocusedStage = null;
>> 61:
> 
> These two can be instance fields (which is usually preferred for test variables).

They are called from the following static method:
    @BeforeClass
    public static void initFX() throws Exception {
        initFXBase();
    }

-------------

PR: https://git.openjdk.java.net/jfx/pull/153


More information about the openjfx-dev mailing list