RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle. [v5]
Kevin Rushforth
kcr at openjdk.java.net
Thu Aug 13 19:52:18 UTC 2020
On Thu, 13 Aug 2020 19:40:02 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
> The fix looks good now. I'll file a follow-up issue for the potential leak on the other platforms.
>
> My thinking is that if `focusedWindow` is only used in Monocle, we should push the tracking down to the platform rather
> than tracking it in the base class. Alternatively, we could have a platform-specific attribute that indicates whether
> to track (and leave it null otherwise).
I filed [JDK-8251555](https://bugs.openjdk.java.net/browse/JDK-8251555) to track the follow-on issue.
-------------
PR: https://git.openjdk.java.net/jfx/pull/153
More information about the openjfx-dev
mailing list