RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v4]

Kevin Rushforth kcr at openjdk.java.net
Wed Aug 26 15:31:01 UTC 2020


On Wed, 26 Aug 2020 15:21:48 GMT, Bhawesh Choudhary <bchoudhary at openjdk.org> wrote:

>> Added missing explicit no-arg constructors to classes in package javafx.scene, javafx.css and javafx.stage.
>
> Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated comments as per JDK convention

Looks good except for the one you missed to update, `StringStore`.

modules/javafx.graphics/src/main/java/javafx/css/StyleConverter.java line 544:

> 543:          */
> 544:         public StringStore() {
> 545:         }

You missed updating the wording for this one.

-------------

PR: https://git.openjdk.java.net/jfx/pull/283


More information about the openjfx-dev mailing list