RFR: 8218973: SVG with masking is not rendering image with mask effect [v8]

Bhawesh Choudhary bchoudhary at openjdk.java.net
Wed Aug 26 18:46:41 UTC 2020


> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to WCGraphicsPrismContext.java  While rendering in
> WCGraphicsPrismContext.java if image clip mask is available, use it for rendering using MaskTextureGraphics interface
> otherwise use usual way of rendering.

Bhawesh Choudhary has updated the pull request with a new target base due to a merge or a rebase. The incremental
webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits
since the last revision:

 - Merge branch 'master' into clip_mask_support
 - Removed RenderSVGResourceMasker changes and added fix for HIDPI mask rendering
 - HiDPI printing and Rendering fix
 - Removed unnecessery Ceil Functions
 - Refactoring, Utilize getFilterContext() function
 - Moved Printing drawing path to non MaskTextureGraphics interface
 - added dispose of resources
 - Formatting correction (Line Endings)
 - removed executable file mode
 - Added unit test + SW Graphics rendering part
 - ... and 2 more: https://git.openjdk.java.net/jfx/compare/31912a00...b1299ba1

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/213/files
  - new: https://git.openjdk.java.net/jfx/pull/213/files/ef47709f..b1299ba1

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/213/webrev.07
 - incr: https://webrevs.openjdk.java.net/jfx/213/webrev.06-07

  Stats: 404841 lines in 5801 files changed: 202048 ins; 139986 del; 62807 mod
  Patch: https://git.openjdk.java.net/jfx/pull/213.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/213/head:pull/213

PR: https://git.openjdk.java.net/jfx/pull/213


More information about the openjfx-dev mailing list