RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina

[Kevin Rushforth]

On Thu, 3 Dec 2020 09:14:00 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> Note to testers: `JFXPanel` applications deadlock with this fix. I need to check whether glass is being started up for a normal Taskbar application, and not being embedded in an `FXCanvas` or `JFXPanel`.
>
> I tested the patch, and it works for me (MacOS Catalina, 10.15.7)
> I will look into more detail in the code, as I'm slightly worried about not following the Apple conventions. From experience, this often leads to more issues sooner or later.

Thanks for checking. I'll remove the debug print statements, turn off verbose logging, and send it out for review. I would appreciate a thorough review of the code. Given the way JavaFX initializes the macOS application and sets the system menu bar, this seems like the least intrusive and least risky fix, but it would be nice if we can find a better fix that isn't overly complicated or risky.

-------------

PR: https://git.openjdk.java.net/jfx/pull/361