RFR: 8247576: Labeled/SkinBase: misbehavior on switching skin [v2]

Jeanette Winzenburg fastegal at openjdk.java.net
Mon Dec 7 10:36:31 UTC 2020


On Mon, 7 Dec 2020 06:18:09 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed outdated code comment
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java line 286:
> 
>> 284:             }
>> 285:         } else {
>> 286:             // FIXME: this listener must be removed in dispose!
> 
> minor: the FIXME note should be removed.

thanks for spotting it :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/355


More information about the openjfx-dev mailing list